Skip to content

Commit d2fd2b3

Browse files
authored
Merge pull request #22 from tompetrovic/fix-order-ratio-string-serialization
Serialize Order's ratio as String to avoid precision loss
2 parents fcfb954 + 68f48b9 commit d2fd2b3

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/main/java/io/zksync/domain/swap/Order.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,25 +55,25 @@ public void setRecipient(String recipientAddress) {
5555
}
5656

5757
@JsonGetter("ratio")
58-
public List<BigInteger> getRatioJson() {
59-
return Arrays.asList(ratio.component1(), ratio.component2());
58+
public List<String> getRatioJson() {
59+
return Arrays.asList(ratio.component1().toString(), ratio.component2().toString());
6060
}
6161

6262
@JsonSetter("ratio")
63-
public void setRatio(List<BigInteger> ratio) {
63+
public void setRatio(List<String> ratio) {
6464
if (ratio == null || ratio.size() != 2) {
6565
throw new IllegalArgumentException("Incorrect amount of ratio");
6666
}
67-
this.ratio = new Tuple2<>(ratio.get(0), ratio.get(1));
67+
this.ratio = new Tuple2<>(new BigInteger(ratio.get(0)), new BigInteger(ratio.get(1)));
6868
}
6969

7070
@JsonGetter("amount")
71-
public String getAmountSrting() {
71+
public String getAmountString() {
7272
return amount.toString();
7373
}
7474

7575
@JsonSetter("amount")
76-
public void getAmountSrting(String amount) {
76+
public void setAmountString(String amount) {
7777
this.amount = new BigInteger(amount);
7878
}
7979

src/main/java/io/zksync/domain/transaction/Transfer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ public class Transfer implements ZkSyncTransaction {
4747
private TimeRange timeRange;
4848

4949
@JsonGetter("amount")
50-
public String getAmountSrting() {
50+
public String getAmountString() {
5151
return amount.toString();
5252
}
5353

5454
@JsonSetter("amount")
55-
public void getAmountSrting(String amount) {
55+
public void setAmountString(String amount) {
5656
this.amount = new BigInteger(amount);
5757
}
5858

src/main/java/io/zksync/domain/transaction/Withdraw.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ public class Withdraw implements ZkSyncTransaction {
4343
private TimeRange timeRange;
4444

4545
@JsonGetter("amount")
46-
public String getAmountSrting() {
46+
public String getAmountString() {
4747
return amount.toString();
4848
}
4949

5050
@JsonSetter("amount")
51-
public void getAmountSrting(String amount) {
51+
public void setAmountString(String amount) {
5252
this.amount = new BigInteger(amount);
5353
}
5454

0 commit comments

Comments
 (0)