feat: add support for github container registry #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the github container registry
This PR adds support for the github container registry and works quite similarly to the docker implementation but also quite different and important implementation differences.
Issues/Limitations
ImageIndexis not returned. A singleImageManifestis returned though. It also does not seem to not return an auth token if the image is being fetched via digest (eg super-linter@sha256:83d590890328d42191c974cb1dceba0d3ad4a994a1e306e73d50d64218bd23ab).The consequence of this is that:
latesttag.fetch_indexis redundant for Github registry (but required for docker and presumably the not-yet-implemented Google container registry), making the oci trait a little inconsistent (cos a method is more specific to a registry)Testing
You can use the public super-linter image to test.
something like:
msb pull ghcr.io github/super-linterPost-merge/Implementation to-do