Skip to content

PlaywrightBrowser: configurable timeout and waiting assertions #199

Description

@kbond

Playwright auto-waits on actions but not on queries: click() retries until the element is actionable, while assertVisible() is a one-shot check. That split is why the waitUntil*() methods exist alongside the assertions.

Two things worth doing:

  • make the timeout configurable, since it is Playwright's 30s default today, which is long for an assertion
  • consider making the assertions retry, which would make most of waitUntil*() redundant

playwright-php/playwright-symfony#35 does the retrying idea for PlaywrightTestCase's own assertion trait, which we don't use, but it is the same shape.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions