Work with memory buffers instead of files

[nurupo]

Toxcore's save/load functions don't deal with the file system, they just take a buffer and return a buffer. That provides some freedom because users can decide how to save the buffer: either in a file using a specific format they want (base64 encoding and saving as a part of a xml file), in a database, or somehow else.

This also will make it easier to switch from using unencrypted save/load functions to using encrypted ones, since it would require less code change.

[ybhvf]

Hmm - it wouldn't be difficult to rewrite the code a bit to add equivalents to Toxcore's current save/load functions. Retrospectively, it's definitely functionality that this library should provide.

This library currently writes to a common save format, which enables clients to drop-in this code without mucking around with files. This has the nice benefit of enabling users to use their tox profiles across different clients. Considering the small size of the file-writing code, I'm personally inclined to keep it and see whether people find it useful. I can, of course, easily amend the code to provide vanilla encrypt/decrypt-to-buffer functions. What do you think?

[nurupo]

Buffers.

[stal888]

lesbians buffers

[ybhvf]

Sorry for the (lengthy) delay. How does this look?

[ybhvf]

Ha - I see that this library is suggested on the GSoC page. Well, I'll abandon the simple branch, add on simple tox_save/load_encrypted() functions, and modify the code to work with buffers rather than files.