Skip to content

Clickhouse default resource request/limits templated wrongly #3165

Description

@fekaiser

Component(s)

helm

Component version

0.15.0

wgc version

controlplane version

0.165.0

router version

0.259.1

What happened?

Description

The template for setting cpu and memory requests/limits is templated wrong:
Current template in values.yaml on main:

# ClickHouse for the Cosmo Controlplane & Collectors
# https://artifacthub.io/packages/helm/bitnami/clickhouse
clickhouse:
  image:
    registry: docker.io
    repository: bitnamilegacy/clickhouse
  shards: 1
  # 1 replica for development
  replicaCount: 1
  # 1 replica for development
  zookeeper:
    enabled: false
  resources:
    memory: 2Gi
    cpu: 1

But it should be:

# ClickHouse for the Cosmo Controlplane & Collectors
# https://artifacthub.io/packages/helm/bitnami/clickhouse
clickhouse:
  image:
    registry: docker.io
    repository: bitnamilegacy/clickhouse
  shards: 1
  # 1 replica for development
  replicaCount: 1
  # 1 replica for development
  zookeeper:
    enabled: false
  resources:
    requests:
      memory: 2Gi
      cpu: 1
    limits:
      memory: <...>
      cpu: <...>

according to the clickhouse chart that's used: https://github.com/bitnami/charts/blob/clickhouse/6.2.14/bitnami/clickhouse/values.yaml#L195-L211

Steps to Reproduce

Render like this:

helm template cosmo ./cosmo -s charts/clickhouse/templates/statefulset.yaml

resources definition is without requests/limits.

Expected Result

resources definition with requests/limits attributes.

Actual Result

resources definition without requests/limits, gets silently ignored by helm.

Environment information

Router configuration

Router execution config

Log output

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions