Normalize user update/create editor preference flags

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>

Author: Copilot

features/user.feature

@@ -919,3 +919,56 @@ Feature: Manage WordPress users
       """
       false
       """
+
+  Scenario: The rich editing preference is normalized when updating a user
+    Given a WP install
+
+    When I run `wp user create frank frank@example.com --porcelain`
+    Then STDOUT should be a number
+    And save STDOUT as {USER_ID}
+
+    When I run `wp user update {USER_ID} --rich_editing=0`
+    Then STDOUT should contain:
+      """
+      Success: Updated user {USER_ID}.
+      """
+
+    When I run `wp user meta get {USER_ID} rich_editing`
+    Then STDOUT should be:
+      """
+      false
+      """
+
+  Scenario: The syntax highlighting preference is stored as the value core checks for
+    Given a WP install
+
+    # wp_get_user_editor() compares the stored meta against the string 'false',
+    # so other spellings of a boolean have to be normalised.
+    When I run `wp user create sasha sasha@example.com --syntax_highlighting=0 --porcelain`
+    Then STDOUT should be a number
+    And save STDOUT as {USER_ID}
+
+    When I run `wp user meta get {USER_ID} syntax_highlighting`
+    Then STDOUT should be:
+      """
+      false
+      """
+
+  Scenario: The syntax highlighting preference is normalized when updating a user
+    Given a WP install
+
+    When I run `wp user create steve steve@example.com --porcelain`
+    Then STDOUT should be a number
+    And save STDOUT as {USER_ID}
+
+    When I run `wp user update {USER_ID} --syntax_highlighting=0`
+    Then STDOUT should contain:
+      """
+      Success: Updated user {USER_ID}.
+      """
+
+    When I run `wp user meta get {USER_ID} syntax_highlighting`
+    Then STDOUT should be:
+      """
+      false
+      """

src/User_Command.php

@@ -385,6 +385,11 @@ function ( $user ) use ( $network, $reassign ) {
 	 * or their numeric forms 1 and 0.
 	 * Default: true
 	 *
+	 * [--syntax_highlighting=<syntax_highlighting>]
+	 * : Whether to enable the rich code editor for the user. Accepts 'true' or 'false',
+	 * or their numeric forms 1 and 0.
+	 * Default: true
+	 *
 	 * [--send-email]
 	 * : Send an email to the user with their new account details.
 	 *
@@ -403,7 +408,7 @@ function ( $user ) use ( $network, $reassign ) {
 	 *     4
 	 *
 	 * @param array{0: string, 1: string} $args Positional arguments.
-	 * @param array{role?: string, user_pass?: string, user_registered?: string, display_name?: string, user_nicename?: string, user_url?: string, nickname?: string, first_name?: string, last_name?: string, description?: string, rich_editing?: string, send_email?: bool, porcelain?: bool} $assoc_args Associative arguments.
+	 * @param array{role?: string, user_pass?: string, user_registered?: string, display_name?: string, user_nicename?: string, user_url?: string, nickname?: string, first_name?: string, last_name?: string, description?: string, rich_editing?: string, syntax_highlighting?: string, send_email?: bool, porcelain?: bool} $assoc_args Associative arguments.
 	 */
 	public function create( $args, $assoc_args ) {
 		$user = new stdClass();
@@ -445,6 +450,9 @@ public function create( $args, $assoc_args ) {
 		$rich_editing       = Utils\get_flag_value( $assoc_args, 'rich_editing', true );
 		$user->rich_editing = filter_var( $rich_editing, FILTER_VALIDATE_BOOLEAN ) ? 'true' : 'false';
 
+		$syntax_highlighting       = Utils\get_flag_value( $assoc_args, 'syntax_highlighting', true );
+		$user->syntax_highlighting = filter_var( $syntax_highlighting, FILTER_VALIDATE_BOOLEAN ) ? 'true' : 'false';
+
 		if ( isset( $assoc_args['user_pass'] ) ) {
 			$user->user_pass = $assoc_args['user_pass'];
 		} else {
@@ -544,12 +552,12 @@ public function create( $args, $assoc_args ) {
 	 * : A string containing content about the user.
 	 *
 	 * [--rich_editing=<rich_editing>]
-	 * : Whether to enable the rich editor for the user. Accepts 'true' or
-	 * 'false' as a string literal, not boolean.
+	 * : Whether to enable the rich editor for the user. Accepts 'true' or 'false',
+	 * or their numeric forms 1 and 0.
 	 *
 	 * [--syntax_highlighting=<syntax_highlighting>]
-	 * : Whether to enable the rich code editor for the user. Accepts 'true' or
-	 * 'false' as a string literal, not boolean.
+	 * : Whether to enable the rich code editor for the user. Accepts 'true' or 'false',
+	 * or their numeric forms 1 and 0.
 	 *
 	 * [--comment_shortcuts=<comment_shortcuts>]
 	 * : Whether to enable comment moderation keyboard shortcuts for the user.
@@ -624,6 +632,11 @@ public function update( $args, $assoc_args ) {
 		}
 
 		$assoc_args = Utils\parse_shell_arrays( $assoc_args, [ 'meta_input' ] );
+		foreach ( [ 'rich_editing', 'syntax_highlighting' ] as $preference ) {
+			if ( isset( $assoc_args[ $preference ] ) ) {
+				$assoc_args[ $preference ] = filter_var( $assoc_args[ $preference ], FILTER_VALIDATE_BOOLEAN ) ? 'true' : 'false';
+			}
+		}
 
 		$assoc_args = wp_slash( $assoc_args );
 		parent::_update( $user_ids, $assoc_args, 'wp_update_user' );