chore(weave): Fix basic type errors in sdks/node/examples#6915
Merged
drtangible merged 1 commit intoMay 22, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=1ab6beab8602b911a098bf0ef6e4c2ef3ea75f43 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
drtangible
force-pushed
the
05-20-chore_weave_fix_basic_type_errors_in_sdks_node_examples
branch
2 times, most recently
from
90f7f17 to
b42ef98
Compare
drtangible
force-pushed
the
05-20-chore_weave_add_scripts_for_typechecking_against_various_tsconfigs
branch
from
0702784 to
9ae5161
Compare
drtangible
changed the title
sdks/node/examples
drtangible
force-pushed
the
05-20-chore_weave_fix_basic_type_errors_in_sdks_node_examples
branch
from
b42ef98 to
9a9754e
Compare
drtangible
force-pushed
the
05-20-chore_weave_add_scripts_for_typechecking_against_various_tsconfigs
branch
from
9ae5161 to
1af3976
Compare
drtangible
force-pushed
the
05-20-chore_weave_fix_basic_type_errors_in_sdks_node_examples
branch
from
9a9754e to
c0e0aaf
Compare
drtangible
force-pushed
the
05-20-chore_weave_add_scripts_for_typechecking_against_various_tsconfigs
branch
from
1af3976 to
0083c71
Compare
Base automatically changed from
05-20-chore_weave_add_scripts_for_typechecking_against_various_tsconfigs
to
master
May 21, 2026 19:14
drtangible
force-pushed
the
05-20-chore_weave_fix_basic_type_errors_in_sdks_node_examples
branch
2 times, most recently
from
3532c87 to
612e2d0
Compare
This was referenced May 21, 2026
chance-wnb
approved these changes
May 22, 2026
Contributor
chance-wnb
left a comment
chance-wnb
left a comment
There was a problem hiding this comment.
Yes, the scorers type is intriguing. we can leave for later.
Thanks!
drtangible
force-pushed
the
05-20-chore_weave_fix_basic_type_errors_in_sdks_node_examples
branch
from
612e2d0 to
9cc8597
Compare
drtangible
deleted the
05-20-chore_weave_fix_basic_type_errors_in_sdks_node_examples
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that
pnpm typecheck:examplessurfaces type errors in theexamples/, fixing the straight-forward ones: updatingid-->namein a couple of places, and adding dev dependencies used in the examples.A few remaining ones are
ts-ignore-d, since I want to better understand the type inference happening around thescorersoption toEvaluation.