chore(weave): Add scripts for typechecking against various tsconfigs#6912
Merged
drtangible merged 3 commits intoMay 21, 2026
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=9e5489d2121cc70d8e9c55eba9a823f2a41ddb5a |
| "path": "../src/tsconfig.src.json" | ||
| } | ||
| ] | ||
| "target": "es2022", |
Collaborator
There was a problem hiding this comment.
@chance-wnb can you confirm this is permissive enough?
Contributor
There was a problem hiding this comment.
AFAIK, this works.
However @drtangible do you think we should encourage users to adopt ESM as much as possible?
Contributor
Author
There was a problem hiding this comment.
Makes sense, as long as something is surfacing the type issues in examples/ 👌. Will update the commonjs below.
9ae5161 to
1af3976
Compare
1af3976 to
0083c71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
sdks/node/examples/directory have some type mismatches. eg:These failures don't currently break the build or fail CI, but might as well make the examples accurate.
This change adds a few convenience scripts for typechecking against the various tsconfigs we have in the SDK:
pnpm typecheck:cjspnpm typecheck:esmpnpm typecheck:examplesWill fix these failing example types in a subsequent PR: