Update accessibility guidelines for tab and tabpanel #2690
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR to add duplication of requirements between tab and tabpanel - see #2500 (comment) note i also duplicated the author should requirement for programmatically associating the tab with the tabpanel, since that seems important to call out these options re: validator/validator#1817
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR duplicates accessibility requirements between the tab and tabpanel role definitions to ensure consistency in documentation. The changes align with W3C ARIA issue #2500 and validator issue #1817, ensuring that both roles document the MUST requirement for rendering active tabs/panels and the SHOULD requirement for programmatic association.
- Adds the active tab/tabpanel rendering requirement to both role definitions
- Documents association methods using
aria-controlsandaria-labelledbyin both sections - Adds HTML comments to mark synchronized content blocks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add duplication of requirements between tab and tabpanel - see #2500 (comment)
note i also duplicated the author should requirement for programmatically associating the tab with the tabpanel, since that seems important to call out these options re: validator/validator#1817
Preview | Diff