Skip to content

Commit cae4461

Browse files
committed
fix more tests
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1 parent 705bb98 commit cae4461

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

encodings/zigzag/public-api.lock

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ pub fn vortex_zigzag::ZigZag::serialize(&self, _options: &vortex_array::scalar_f
4242

4343
pub fn vortex_zigzag::ZigZag::validity(&self, _options: &vortex_array::scalar_fn::vtable::EmptyOptions, expression: &vortex_array::expr::expression::Expression) -> vortex_error::VortexResult<core::option::Option<vortex_array::expr::expression::Expression>>
4444

45+
pub fn vortex_zigzag::initialize(session: &vortex_session::VortexSession)
46+
4547
pub fn vortex_zigzag::zigzag_decode(parray: vortex_array::arrays::primitive::vtable::PrimitiveArray) -> vortex_array::arrays::primitive::vtable::PrimitiveArray
4648

4749
pub fn vortex_zigzag::zigzag_encode(parray: vortex_array::array::view::ArrayView<'_, vortex_array::arrays::primitive::vtable::Primitive>) -> vortex_error::VortexResult<vortex_array::array::erased::ArrayRef>

vortex-array/public-api.lock

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22084,8 +22084,6 @@ pub fn vortex_array::ArrayRef::is_valid(&self, index: usize) -> vortex_error::Vo
2208422084

2208522085
pub fn vortex_array::ArrayRef::len(&self) -> usize
2208622086

22087-
pub fn vortex_array::ArrayRef::metadata(&self, session: &vortex_session::VortexSession) -> vortex_error::VortexResult<core::option::Option<alloc::vec::Vec<u8>>>
22088-
2208922087
pub fn vortex_array::ArrayRef::metadata_fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result
2209022088

2209122089
pub fn vortex_array::ArrayRef::named_buffers(&self) -> alloc::vec::Vec<(alloc::string::String, vortex_array::buffer::BufferHandle)>

vortex-cuda/src/hybrid_dispatch/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,7 @@ mod tests {
241241
let session = VortexSession::empty();
242242
fastlanes::initialize(&session);
243243
session.arrays().register(ZstdBuffers);
244+
244245
let mut ctx = CudaSession::create_execution_ctx(&session).vortex_expect("ctx");
245246

246247
let num_values: u32 = 64;
@@ -257,8 +258,7 @@ mod tests {
257258
0u32.into(),
258259
)
259260
.vortex_expect("for");
260-
let vals = ZstdBuffers::compress(&vals.into_array(), 3, &VortexSession::empty())
261-
.vortex_expect("zstd");
261+
let vals = ZstdBuffers::compress(&vals.into_array(), 3, &session).vortex_expect("zstd");
262262

263263
// codes = FoR(BitPacked)
264264
let codes = PrimitiveArray::new(

vortex-python/test/test_compress.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,6 @@ def test_arrange_encode():
3232
assert compressed.nbytes < a.nbytes
3333

3434

35-
def test_zigzag_encode():
36-
a = vortex.array(pa.array([-1, -1, 0, -1, 1, -1]))
37-
zarr = vortex.ZigZagArray.encode(a)
38-
assert isinstance(zarr, vortex.ZigZagArray)
39-
# TODO(ngates): support decoding once we have decompressor.
40-
41-
4235
def test_chunked_encode():
4336
chunked = pa.chunked_array([pa.array([0, 1, 2]), pa.array([3, 4, 5])])
4437
encoded = vortex.array(chunked)

0 commit comments

Comments
 (0)