Repository navigation
Rewrite vite imports when vp create adds a package to a monorepo - #3282
Open
voidzero-bot[bot] wants to merge 1 commit into
Open
voidzero-bot[bot] wants to merge 1 commit into
voidzero-bot[bot] wants to merge 1 commit into
Conversation
4 tasks done
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://triagebot-fix-3281-viteplus-dev.voidzero-docs.workers.dev (commit 4c24e51)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
vp createadds a third-party template to an existing Vite+ monorepo, it integrates the new package by callingrewriteMonorepoProject(..., deferLazyPluginWrapping = false). That function wrapped inline plugins withlazyPluginsbut never ranrewriteAllImports, sodefineConfigstayed imported from"vite". This causedvp checkto fail withvite-plus/prefer-vite-plus-importson the generatedvite.config.ts.The full
rewriteMonorepoorchestrator already rewrites imports once for the whole workspace before deferring per-project plugin wrapping, and the standalonerewriteStandaloneProjectrewrites imports before wrapping too. This change brings the directrewriteMonorepoProjectpath in line with both of them.oxlintOwnerDirsbeforerewritePackageJsonstripsoxlintfrom the manifest.deferLazyPluginWrappingisfalse, runrewriteAllImports(projectPath, ...)beforewrapLazyPluginsInViteConfig.Added a regression test that drives a third-party-style
vite.config.tsthroughrewriteMonorepoProjectand asserts theviteimport is rewritten tovite-pluswhile the plugin array is still wrapped.Closes #3281