-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Use git command to fetch pinned SHAs, pin goimports
#18980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use git command to fetch pinned SHAs, pin goimports
#18980
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
go-git to fetch pinned SHAs, pin goimports
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Matt Lord <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18980 +/- ##
==========================================
+ Coverage 69.77% 69.82% +0.05%
==========================================
Files 1608 1610 +2
Lines 214908 215360 +452
==========================================
+ Hits 149953 150385 +432
- Misses 64955 64975 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <[email protected]>
|
@mattlord thanks for the suggestion on using the I believe this is now ready for re-review when you have time! |
mattlord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
@timvaillancourt don't forget to change the title and description🙂 |
go-git to fetch pinned SHAs, pin goimportsgit commit to fetch pinned SHAs, pin goimports
git commit to fetch pinned SHAs, pin goimportsgit command to fetch pinned SHAs, pin goimports
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Description
This PR resolves many more code scanning complaints (example) by moving more workflow dependencies to pinned Git SHAs
On my 1st attempt at pinning workflow dependencies, I used a GitHub-specific golang library to fetch the Git SHA, but it turns out some dependencies (
goimportsfor example) are not hosted on GitHub. So this PR also moves to using a thegitcommand for fetching SHAs instead (called viaos/exec)Related Issue(s)
Example code scanning alert: https://github.com/vitessio/vitess/security/code-scanning/1794
Checklist
Deployment Notes
AI Disclosure