Skip to content

Commit 8ce3eb2

Browse files
ci: remove code patching for error differences between versions (#18990)
Signed-off-by: Arthur Schreiber <[email protected]>
1 parent 719bd95 commit 8ce3eb2

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

.github/workflows/upgrade_downgrade_test_query_serving_queries.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -142,15 +142,6 @@ jobs:
142142
run: |
143143
find ./go/test/endtoend -name '*.go' -exec sed -i 's/ErrorContains/Error/g' {} +
144144
find ./go/test/endtoend -name '*.go' -exec sed -i 's/EqualError/Error/g' {} +
145-
# Relax TestSpecializedPlan for < v24 due to window functions error message change.
146-
# <= v23: "VT12001: unsupported: OVER CLAUSE with sharded keyspace"
147-
# >= v24: "VT12001: unsupported: window functions are only supported for single-shard queries"
148-
# Use Contains check to accept both versions.
149-
ref="${{ steps.output-previous-release-ref.outputs.previous_release_ref }}"
150-
version=$(echo "$ref" | sed 's/release-//' | cut -d. -f1)
151-
if [ "$version" -lt 24 ]; then
152-
sed -i 's/require\.EqualValues(t, "VT12001: unsupported: OVER CLAUSE with sharded keyspace", pm\["BaselineErr"\])/require.Contains(t, pm["BaselineErr"].(string), "VT12001: unsupported:")/' go/test/endtoend/preparestmt/stmt_methods_test.go
153-
fi
154145
155146
# Swap the binaries in the bin. Use vtgate version n-1 and keep vttablet at version n
156147
- name: Use last release's VTGate

0 commit comments

Comments
 (0)