fix(slider): add null check for this.bar.el_ before accessing ownerDocument#9191
Open
xxiaoxiong wants to merge 1 commit into
Open
fix(slider): add null check for this.bar.el_ before accessing ownerDocument#9191xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
…cument Fixes videojs#9184 ## Why Both disable() and handleMouseDown() access this.bar.el_.ownerDocument without checking if this.bar or this.bar.el_ exists. If a subclass or custom slider is created without a proper bar child component, this.bar would be undefined, causing a TypeError. ## Changes - disable(): early return if this.bar or this.bar.el_ is null/undefined - handleMouseDown(): early return if this.bar or this.bar.el_ is null/undefined ## Testing No longer throws when bar is missing or has no element. Consistent with existing this.bar check in update() (line 245).
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9184
Why
Both
disable()andhandleMouseDown()accessthis.bar.el_.ownerDocumentwithout checking ifthis.barorthis.bar.el_exists. If a subclass or custom slider is created without a proper bar child component,this.barwould beundefined, causing a TypeError.Changes
disable(): early return ifthis.barorthis.bar.el_is null/undefinedhandleMouseDown(): early return ifthis.barorthis.bar.el_is null/undefinedTesting
No longer throws when bar is missing or has no element. Consistent with the existing null check in
update()at line 245.Surface area