Commit 9216589

committed

feat(parse_size): Add comprehensive builder validation to prevent fragile configurations

Addresses PR #9653 review feedback about 'fragile commands' by implementing fail-fast validation in Parser builder pattern. Changes: - Add ParserBuilderError enum with 8 validation error variants - Refactor builder methods to return Result<&mut Self, ParserBuilderError> - Implement comprehensive unit validation (57 valid units including k/m/g/t) - Add cross-validation between builder settings (default_unit vs allow_list) - Detect conflicts (b_byte_count with 'b' unit, '%' with size units) - Update all call sites (sort, du, df, od) to handle new error types - Fix invalid '%' unit in sort's parse_byte_count allow_list Benefits: - Configuration errors detected immediately (not during parsing) - Clear error messages listing invalid/conflicting settings - Maintains backward compatibility through explicit error reporting Files modified: - src/uucore/src/lib/features/parser/parse_size.rs (core implementation) - src/uu/sort/src/sort.rs (error handling + fix invalid '%') - src/uu/du/src/du.rs (error handling) - src/uu/df/src/df.rs (error handling) - src/uu/od/src/od.rs (error handling)

1 parent 2787f9e commit 9216589Copy full SHA for 9216589

8 files changed

gnu_coreutils
plans
- enhanced_validation_rules.md
- parse_size_error_handling_strategy.md
src
- uucore/src/lib/features/parser
  - parse_size.rs
- uu
  - df/src
    - df.rs
  - du/src
    - du.rs
  - od/src
    - od.rs
  - sort/src
    - sort.rs

`‎gnu_coreutils‎`

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 7e1b4f76d3f07a11edb8d5babc7a078aefdd2ba0`

Comments

(0)