feat: Compose file build options #2497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex-Andrei Cioc <[email protected]>
Signed-off-by: Alex-Andrei Cioc <[email protected]>
nderjung
reviewed
Oct 10, 2025
Signed-off-by: Alex-Andrei Cioc <[email protected]>
nurof3n
force-pushed
the
nurof3n/compose-build-options
branch
from
9d060f3 to
3f94bb2
Compare
nderjung
reviewed
Oct 13, 2025
initrd/rootfs.go
Outdated
| // BuildRootfs generates a rootfs based on the provided working directory and | ||
| // the rootfs entrypoint for the provided target(s). | ||
| func BuildRootfs(ctx context.Context, workdir, rootfs string, compress bool, arch string) (initrd.Initrd, []string, []string, error) { | ||
| func BuildRootfs(ctx context.Context, workdir, rootfs string, compress bool, arch string, initrdOptions []InitrdOption) (Initrd, []string, []string, error) { |
Member
There was a problem hiding this comment.
Let's turn the prototype into an options pattern:
- func BuildRootfs(ctx context.Context, workdir, rootfs string, compress bool, arch string, initrdOptions []InitrdOption) (Initrd, []string, []string, error) {
+ func BuildRootfs(ctx context.Context, opts ...InitrdOption) (Initrd, []string, []string, error) {Later:
var bopts InitrdOoptions
for _, opt := range opts {
if err := opt(&bopts); err != nil {
return nil, nil, nil, err
}
}
Contributor
Author
There was a problem hiding this comment.
with these changes the processing of paths is moved to the callers, do you want me to move it inside WithOutput and WithCacheDir?
Signed-off-by: Alex-Andrei Cioc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Add support for specifying the following service build options in the
compose.yamlfile, when usingkraft cloud composeandkraft compose: