-
Notifications
You must be signed in to change notification settings - Fork 2.8k
User group: add description to user group (discussions/14986) #21057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Maybe the icon should be aligned at top close to user group name, when some user group may have no description, others longer description and some one or many sections selected. |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @LanThuyNguyen, nice to see a "full-stack" feature as one contribution! I had a few code comments which I've left inline. Please could you have a look at addressing them, and then tomorrow I'll pull it down for some testing.
src/Umbraco.Cms.Api.Management/ViewModels/UserGroup/UserGroupBase.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Migrations/Upgrade/V_17_0_1/AddDescriptionToUserGroup.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Migrations/Upgrade/V_17_0_1/AddDescriptionToUserGroup.cs
Outdated
Show resolved
Hide resolved
...o.Web.UI.Client/src/packages/multi-url-picker/link-picker-modal/link-picker-modal.element.ts
Show resolved
Hide resolved
tests/Umbraco.Tests.Integration/Umbraco.Core/Services/UserGroupServiceTests.cs
Show resolved
Hide resolved
|
Thank you @AndyButland , I updated my PR I also updated the user group Icon so to make it consistent with the Document type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an issue with the migration logic (likely after you refactored it following my first comment), which I've pushed a fix for.
Otherwise it all looks to work nicely.
There's small small styling alignment issues around the header where you edit the name, icon and description.
If you look at the document type one you'll see:
- The icon border only appears when you hover over it.
- The icon border aligns nicely with the top and bottom of the name and description text boxes
That's not the case for the user group header:
I think it might be nice to add the description to the collection view of user groups. Seems like there's room without it getting two cluttered. Perhaps best to truncate the input though so if it's more than a couple of lines long it gets truncated with an ellipsis (...).
…7/add-description-to-user-group
…7/add-description-to-user-group
|
Thanks @AndyButland , I have just updated as images below |
|
The description in the collection looks good @LanThuyNguyen, and nice how you have presented the whole description in the hover text if it's truncated. I still see the visual discrepancy between the document type and user group header though. For the document type, if you hover over the icon you can see the border aligns nicely with the top of the name field. For the user group, it doesn't. Looks to me that there's more padding between the top bar and the name field for the document type than we have for the user group. |
|
@AndyButland , Yes, I updated it. I was too focused on the icon 😁 |
|
@ronaldbarendse @KevinJump - you may need a heads-up about this. We are looking to add a description to user groups. I don't recall that Deploy supports user group schema deployments, and not sure about uSync, but in case either does or you have it in mind, please be aware of this PR. |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me from a back-end and testing perspective @LanThuyNguyen, great work.
@iOvergaard or @leekelleher - to me it's all fine on the front-end too, but maybe one of you could have a quick look-over from that perspective too please?
@NguyenThuyLan - to finish off, it would be worth reviewing the documentation on user groups please, and see if you can see any places where we should update text or screenshots to include reference to this new description field. If so, please create a PR for the docs with it marked as ready for release with the 17.1-rc (23/12/2025).
@nhudinh0309 - maybe you could look too here please, to see if we should update any E2E tests to verify we can create and update user groups with description fields.





Description
This pull request introduces a new description field for user groups. The purpose of this update is to provide additional context and clarity about each group's purpose and usage within the system.
Key Changes
descriptionfield to user group modelsWhy this change
#14986
After change
