-
Notifications
You must be signed in to change notification settings - Fork 6k
feat: automatic session linking and identity stitching #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lokimorty
wants to merge
3
commits into
umami-software:master
Choose a base branch
from
Lokimorty:identity-stitching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+306
−39
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /** | ||
| * Identity Stitching - Links anonymous browser sessions to authenticated user identities | ||
| * | ||
| * Design decisions: | ||
| * - One visitor can link to multiple distinct_ids (user logs into different accounts) | ||
| * - One distinct_id can link to multiple visitors (user on multiple devices/browsers) | ||
| * - Links are additive and never invalidated (preserves historical journey) | ||
| * - Uses ReplacingMergeTree in ClickHouse with linked_at for deduplication | ||
| * - Upsert pattern ensures idempotency for repeated identify() calls | ||
| * | ||
| * Edge cases handled: | ||
| * - Safari private browsing: visitorId will be undefined, no link created | ||
| * - localStorage cleared: new visitorId generated, creates new link | ||
| * - Multiple tabs: same visitorId shared via localStorage | ||
| */ | ||
| import { uuid } from '@/lib/crypto'; | ||
| import prisma from '@/lib/prisma'; | ||
| import clickhouse from '@/lib/clickhouse'; | ||
| import kafka from '@/lib/kafka'; | ||
| import { CLICKHOUSE, PRISMA, runQuery } from '@/lib/db'; | ||
|
|
||
| export interface CreateIdentityLinkArgs { | ||
| websiteId: string; | ||
| visitorId: string; | ||
| distinctId: string; | ||
| } | ||
|
|
||
| export async function createIdentityLink(data: CreateIdentityLinkArgs) { | ||
| return runQuery({ | ||
| [PRISMA]: () => relationalQuery(data), | ||
| [CLICKHOUSE]: () => clickhouseQuery(data), | ||
| }); | ||
| } | ||
|
|
||
| async function relationalQuery({ websiteId, visitorId, distinctId }: CreateIdentityLinkArgs) { | ||
| const { client } = prisma; | ||
|
|
||
| return client.identityLink.upsert({ | ||
| where: { | ||
| websiteId_visitorId_distinctId: { | ||
| websiteId, | ||
| visitorId, | ||
| distinctId, | ||
| }, | ||
| }, | ||
| update: { | ||
| linkedAt: new Date(), | ||
| }, | ||
| create: { | ||
| id: uuid(), | ||
| websiteId, | ||
| visitorId, | ||
| distinctId, | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| async function clickhouseQuery({ websiteId, visitorId, distinctId }: CreateIdentityLinkArgs) { | ||
| const { insert, getUTCString } = clickhouse; | ||
| const { sendMessage } = kafka; | ||
|
|
||
| const now = getUTCString(new Date()); | ||
| const message = { | ||
| website_id: websiteId, | ||
| visitor_id: visitorId, | ||
| distinct_id: distinctId, | ||
| created_at: now, | ||
| linked_at: now, | ||
| }; | ||
|
|
||
| if (kafka.enabled) { | ||
| await sendMessage('identity_link', message); | ||
| } else { | ||
| await insert('identity_link', [message]); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.