Generate update set on conflict for upserts (#145)

When upserting to tables with only key columns, typo would generate `do nothing`
as a conflict resolution. This has the disadvantage of making the query not
execute the `returning` part, which meant that in cases where an upsert was
executed targeting a single row, no rows would return and the generated code
would cause an error.

As a workaround, we generate `update set k = excluded.k` for an arbitrary key
column k instead. This causes the `returning` part of the query to run but
shouldn't change the value of the row as typo sees it.

- Add failing test case for upserting on an existing row
- Make the test case work by generating `update set` instead of `do nothing`

Author: kaaveland

.bleep/generated-sources/typo-tester-anorm@jvm213/scripts.GenHardcodedFiles/testdb/hardcoded/myschema/marital_status/MaritalStatusRepoImpl.scala

@@ -98,7 +98,7 @@ class MaritalStatusRepoImpl extends MaritalStatusRepo {
             ${ParameterValue(unsaved.id, null, MaritalStatusId.toStatement)}::int8
           )
           on conflict ("id")
-          do nothing
+          do update set "id" = EXCLUDED."id"
           returning "id"
        """
       .executeInsert(MaritalStatusRow.rowParser(1).single)

.bleep/generated-sources/typo-tester-anorm@jvm213/scripts.GenHardcodedFiles/testdb/hardcoded/package.scala

@@ -29,7 +29,7 @@ package object hardcoded {
         case "VARCHAR" => "text[]"
         case other => s"${other}[]"
       }
-    
+  
     override def jdbcType: scala.Int = java.sql.Types.ARRAY
   }
 }

.bleep/generated-sources/typo-tester-anorm@jvm3/scripts.GenHardcodedFiles/testdb/hardcoded/myschema/marital_status/MaritalStatusRepoImpl.scala

@@ -98,7 +98,7 @@ class MaritalStatusRepoImpl extends MaritalStatusRepo {
             ${ParameterValue(unsaved.id, null, MaritalStatusId.toStatement)}::int8
           )
           on conflict ("id")
-          do nothing
+          do update set "id" = EXCLUDED."id"
           returning "id"
        """
       .executeInsert(MaritalStatusRow.rowParser(1).single)

.bleep/generated-sources/typo-tester-anorm@jvm3/scripts.GenHardcodedFiles/testdb/hardcoded/package.scala

@@ -29,7 +29,7 @@ package object hardcoded {
         case "VARCHAR" => "text[]"
         case other => s"${other}[]"
       }
-    
+  
     override def jdbcType: scala.Int = java.sql.Types.ARRAY
   }
 }

.bleep/generated-sources/typo-tester-doobie@jvm213/scripts.GenHardcodedFiles/testdb/hardcoded/myschema/marital_status/MaritalStatusRepoImpl.scala

@@ -76,7 +76,7 @@ class MaritalStatusRepoImpl extends MaritalStatusRepo {
             ${fromWrite(unsaved.id)(Write.fromPut(MaritalStatusId.put))}::int8
           )
           on conflict ("id")
-          do nothing
+          do update set "id" = EXCLUDED."id"
           returning "id"
        """.query(using MaritalStatusRow.read).unique
   }

.bleep/generated-sources/typo-tester-doobie@jvm3/scripts.GenHardcodedFiles/testdb/hardcoded/myschema/marital_status/MaritalStatusRepoImpl.scala

@@ -76,7 +76,7 @@ class MaritalStatusRepoImpl extends MaritalStatusRepo {
             ${fromWrite(unsaved.id)(Write.fromPut(MaritalStatusId.put))}::int8
           )
           on conflict ("id")
-          do nothing
+          do update set "id" = EXCLUDED."id"
           returning "id"
        """.query(using MaritalStatusRow.read).unique
   }

.bleep/generated-sources/typo-tester-zio-jdbc@jvm213/scripts.GenHardcodedFiles/testdb/hardcoded/myschema/marital_status/MaritalStatusRepoImpl.scala

@@ -78,7 +78,7 @@ class MaritalStatusRepoImpl extends MaritalStatusRepo {
             ${Segment.paramSegment(unsaved.id)(MaritalStatusId.setter)}::int8
           )
           on conflict ("id")
-          do nothing
+          do update set "id" = EXCLUDED."id"
           returning "id"""".insertReturning(using MaritalStatusRow.jdbcDecoder)
   }
   /* NOTE: this functionality is not safe if you use auto-commit mode! it runs 3 SQL statements */

.bleep/generated-sources/typo-tester-zio-jdbc@jvm3/scripts.GenHardcodedFiles/testdb/hardcoded/myschema/marital_status/MaritalStatusRepoImpl.scala

@@ -78,7 +78,7 @@ class MaritalStatusRepoImpl extends MaritalStatusRepo {
             ${Segment.paramSegment(unsaved.id)(MaritalStatusId.setter)}::int8
           )
           on conflict ("id")
-          do nothing
+          do update set "id" = EXCLUDED."id"
           returning "id"""".insertReturning(using MaritalStatusRow.jdbcDecoder)
   }
   /* NOTE: this functionality is not safe if you use auto-commit mode! it runs 3 SQL statements */

init/data/test-tables.sql

@@ -273,3 +273,9 @@ INSERT INTO issue142 (tabellkode)
 VALUES  ('aa'),
         ('bb')
 ;
+
+create table only_pk_columns(
+    key_column_1 text not null,
+    key_column_2 int not null,
+    constraint only_pk_columns_pk primary key (key_column_1, key_column_2)
+);

typo-tester-anorm/generated-and-checked-in/adventureworks/humanresources/employeedepartmenthistory/EmployeedepartmenthistoryRepoImpl.scala

@@ -111,7 +111,7 @@ class EmployeedepartmenthistoryRepoImpl extends EmployeedepartmenthistoryRepo {
     val shiftid = compositeIds.map(_.shiftid)
     SQL"""select "businessentityid", "departmentid", "shiftid", "startdate"::text, "enddate"::text, "modifieddate"::text
           from "humanresources"."employeedepartmenthistory"
-          where ("businessentityid", "startdate", "departmentid", "shiftid") 
+          where ("businessentityid", "startdate", "departmentid", "shiftid")
           in (select unnest(${businessentityid}), unnest(${startdate}), unnest(${departmentid}), unnest(${shiftid}))
        """.as(EmployeedepartmenthistoryRow.rowParser(1).*)