Skip to content

Conversation

@crandles
Copy link
Contributor

@crandles crandles commented Jul 7, 2025

  • Extends pkg/daemon.Start and pkg/daemon/signaling with context.Context for cancellation
  • Adds an integration top-level package and simple test calling equivalent to trickster binary
  • Adds a new PR workflow job that runs the integration test

I'm aiming to keep the tests high level; more specific backend logic should reside at the backend-package level. The integration tests are meant to test the variety of trickster layers all together.

This should allow for easier step-level debugging / bug report reproduction.

To Do:

  • add prometheus backend tests
    • Not 100% sure of what this test will look like, but the goal is making sure it is reproducible / deterministic (and not flaky).
      • perhaps: Seed prometheus with some data, expect a certain result once queried through trickster.
      • perhaps: query prometheus direct & compare against trickster-proxied result?
  • add method for running trickster via image (ad-hoc)
    • this will allow running new tests vs an older image

@coveralls
Copy link

coveralls commented Jul 7, 2025

Pull Request Test Coverage Report for Build 16105623242

Details

  • 0 of 21 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 76.297%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/trickster/main.go 0 1 0.0%
pkg/daemon/setup/setup.go 0 2 0.0%
pkg/daemon/daemon.go 0 7 0.0%
pkg/daemon/signaling/signaling.go 0 11 0.0%
Totals Coverage Status
Change from base Build 15974287861: 0.005%
Covered Lines: 15325
Relevant Lines: 20086

💛 - Coveralls

crandles added 2 commits July 6, 2025 21:40
Signed-off-by: Chris Randles <[email protected]>
Signed-off-by: Chris Randles <[email protected]>
@crandles crandles added the deprioritized Nice-to-have, but let's resolve other issues first. label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprioritized Nice-to-have, but let's resolve other issues first.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants