Bucket naming needs validation

[nealtodd]

Bucket names cannot, for example, include underscores (see https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-s3-bucket-naming-requirements.html for full naming requirements).

The Bucket name? prompt allows an invalid name but the creation will fail after the Do you want to create a bucket with the above details? prompt with:

botocore.exceptions.ClientError: An error occurred (InvalidBucketName) when calling the CreateBucket operation: The specified bucket is not valid.

[tm-kn]

Thanks!

We currently check for ParamValidationError, but we probably also do check for ClientError. ParamValidationError may have worked before because we might have been using resource rather than the client, so need to evaluate whether it still relevant as well.

buckup/buckup/bucket_creator.py

Lines 159 to 168 in 2b4bfe7

	except ClientError as e:
	# Bucket does not exist, proceed with creation.
	if e.response['Error']['Code'] == '404':
	return
	# No access to the bucket means that it already exists but we
	# cannot run head request on it.
	elif e.response['Error']['Code'] == '403':
	raise BucketNameAlreadyInUse
	else:
	raise e

[tm-kn]

Ah, it fails when creating the bucket... boto3 has a wrong regex for bucket names itself...