-
Notifications
You must be signed in to change notification settings - Fork 917
feat(database): add connect_args support to SqlAlchemyAdapter #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ketanjain3
wants to merge
10
commits into
topoteretes:dev
Choose a base branch
from
ketanjain3:feature/sqlalchemy-custom-connect-args
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+121
−4
Open
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f9b16e5
feat(database): add connect_args support to SqlAlchemyAdapter
ketanjain7981 c892265
fix(database): address CodeRabbit review feedback
ketanjain7981 3f53534
refactor(database): simplify to env var only for connect_args
ketanjain7981 4f3a1bc
test: add unit tests for SQLAlchemyAdapter connection arguments
ketanjain7981 a7da9c7
test: verify logger warning for invalid JSON in SQLAlchemyAdapter
ketanjain7981 1f98d50
Merge branch 'dev' into feature/sqlalchemy-custom-connect-args
ketanjain3 f26b490
refactor: improve test isolation and add connect_args precedence
ketanjain7981 654a573
Merge branch 'dev' into feature/sqlalchemy-custom-connect-args
ketanjain3 e1d313a
move DATABASE_CONNECT_ARGS parsing to RelationalConfig
ketanjain7981 2de1bd9
Merge branch 'dev' into feature/sqlalchemy-custom-connect-args
ketanjain3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.