Fix argument names in the error messages thrown by policy_compression_add
#8394
+124
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilder
force-pushed
the
zilder/add-compression-policy-args
branch
2 times, most recently
from
6928b27 to
91d17c3
Compare
zilder
commented
Jul 17, 2025
Comment on lines
380
to
388
| /* | ||
| * `policy_compression_add` is used by both `add_compression_policy()` and | ||
| * `add_columnstore_policy()`; but thier arguments names differ. We need to | ||
| * respect that in the error messages. | ||
| */ | ||
| if (OidIsValid(fn_oid) && strcmp(get_func_name(fn_oid), "add_columnstore_policy") == 0) | ||
| { | ||
| is_columnstore_policy = true; | ||
| } |
Member
Author
There was a problem hiding this comment.
I could have added two different C functions for policy_compression_add and add_compression_policy to differentiate between them but I thought it would be excessive. Instead I check which SQL function invoked the call.
`add_compression_policy()` and `add_columnstore_policy()` share the same C-function, but their arguments have different names. We have to respect that in the error messages we show users. In this patch we introduce different error messages depending on which SQL function/procedure was invoked.
zilder
force-pushed
the
zilder/add-compression-policy-args
branch
from
91d17c3 to
a534b67
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8394 +/- ##
==========================================
+ Coverage 82.28% 82.35% +0.06%
==========================================
Files 246 246
Lines 46120 46098 -22
Branches 11653 11652 -1
==========================================
+ Hits 37949 37962 +13
- Misses 3488 3504 +16
+ Partials 4683 4632 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@zilder are u planning to continue and finish this PR? |
|
This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8367
add_compression_policy()andadd_columnstore_policy()share the same C-function, but their arguments have different names. We have to respect that in the error messages we show users. In this patch we introduce different error messages depending on which SQL function/procedure was invoked.