Skip to content

Conversation

@akuzm
Copy link
Member

@akuzm akuzm commented Jun 17, 2025

If we have a small dictionary, hashing its entries and then translating the key indexes to the actual rows will be faster.

If we have a small dictionary, hashing its entries and then translating
the key indexes to the actual rows will be faster.
@github-actions
Copy link

@fabriziomello, @erimatnor: please review this pull request.

Powered by pull-review

@akuzm akuzm marked this pull request as draft June 17, 2025 14:38
@akuzm akuzm mentioned this pull request Jun 17, 2025
15 tasks
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 80.61224% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.02%. Comparing base (5a51693) to head (8271e4d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...des/vector_agg/hashing/hash_strategy_single_text.c 79.77% 6 Missing and 12 partials ⚠️
.../src/nodes/vector_agg/hashing/hash_strategy_impl.c 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8270      +/-   ##
==========================================
- Coverage   82.16%   82.02%   -0.14%     
==========================================
  Files         257      256       -1     
  Lines       48323    48643     +320     
  Branches    12189    12277      +88     
==========================================
+ Hits        39704    39899     +195     
- Misses       3741     3884     +143     
+ Partials     4878     4860      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 23, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant