Missing capital POV from NE for region at high zooms

[nvkelso]

• What did you see? Region capitals in Taiwan aren't getting any POV properties at high zooms.
• What did you expect to see? Those should be included by joining from OSM to NE via Wikidata_ID values. That seems to be working for country capitals, but not region capitals.
• What map location are you having problems with? Taiwan
• Screenshot?

Low zoom from Natural Earth:

High zoom from OSM missing NE POV properties:

[nvkelso]

@zerebubuth can you take a look, please?

[nvkelso]

OSM node:

• https://www.openstreetmap.org/node/60655918
  • doesn't have state_capital or capital property
  • does have Relation Taichung (2921154) (as admin_centre)

[tgrigsby-sc]

@nvkelso can you list which of the properties that aren't making it in to the high zoom should be?
I see region_capital, region_capital:cn that seem obviously missing and related, but then I also see a lot of name differences due to the different data sources providing the properties.

One that may be important is, in the low zoom, the name:zh field has a value with 1 less char than in the high zoom. Is this relevant? Anything else?

[tgrigsby-sc]

A lot of this can be modeled off the description here: #2020
Basically, add a join query like in functions.sql, call it to pull the data into the properties that vector datasource sees, then make sure they're exported (probably in places.yaml)

[tgrigsby-sc]

Nm looks like this was already committed.

[peitili]

does that mean we can close this issue?

[tgrigsby-sc]

not sure yet!

[nvkelso]

Yes, we can close this issue. It should have been closed in 2019 via tilezen/raw_tiles#34 and #1907.