Skip to content

Commit bf027cc

Browse files
committed
fix: replace $effect() with svelte-ignore state_referenced_locally
1 parent eeaed7e commit bf027cc

File tree

67 files changed

+312
-351
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+312
-351
lines changed

src/lib/accordion/Accordion.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
const theme = getTheme("accordion");
1212
1313
// Simple reactive state object
14-
const reactivecCtx: AccordionContextType = {
14+
const reactiveCtx: AccordionContextType = {
1515
get flush() {
1616
return flush;
1717
},
@@ -27,7 +27,7 @@
2727
};
2828
2929
// Set context during initialization
30-
setAccordionContext(reactivecCtx);
30+
setAccordionContext(reactiveCtx);
3131
3232
$effect(() => {
3333
createSingleSelectionContext(multiple);

src/lib/accordion/AccordionItem.svelte

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,23 +23,22 @@
2323
contentClass
2424
}: AccordionItemProps = $props();
2525
26-
$effect(() => {
27-
warnThemeDeprecation(
28-
"AccordionItem",
29-
{
30-
headerClass,
31-
contentClass,
32-
activeClass,
33-
inactiveClass
34-
},
35-
{
36-
headerClass: "button",
37-
contentClass: "content",
38-
activeClass: "active",
39-
inactiveClass: "inactive"
40-
}
41-
);
42-
});
26+
// svelte-ignore state_referenced_locally
27+
warnThemeDeprecation(
28+
"AccordionItem",
29+
{
30+
headerClass,
31+
contentClass,
32+
activeClass,
33+
inactiveClass
34+
},
35+
{
36+
headerClass: "button",
37+
contentClass: "content",
38+
activeClass: "active",
39+
inactiveClass: "inactive"
40+
}
41+
);
4342
4443
let styling: typeof classes = $derived(classes ?? { button: headerClass, content: contentClass, active: activeClass, inactive: inactiveClass });
4544

src/lib/badge/Badge.svelte

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@
2626
...restProps
2727
}: BadgeProps = $props();
2828
29-
$effect(() => {
30-
warnThemeDeprecation("Badge", { aClass }, { aClass: "linkClass" });
31-
});
29+
// svelte-ignore state_referenced_locally
30+
warnThemeDeprecation("Badge", { aClass }, { aClass: "linkClass" });
3231
3332
const styling = $derived(classes ?? { linkClass: aClass });
3433

src/lib/banner/Banner.svelte

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@
2424
...restProps
2525
}: BannerProps = $props();
2626
27-
$effect(() => {
28-
warnThemeDeprecation("Banner", { innerClass, closeClass }, { innerClass: "insideDiv", closeClass: "dismissable" });
29-
});
27+
// svelte-ignore state_referenced_locally
28+
warnThemeDeprecation("Banner", { innerClass, closeClass }, { innerClass: "insideDiv", closeClass: "dismissable" });
3029
3130
const styling = $derived(classes ?? { insideDiv: innerClass, dismissable: closeClass });
3231

src/lib/bottom-navigation/BottomNav.svelte

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
99
let { children, header, position = "fixed", navType = "default", class: className, classes, outerClass, innerClass, activeClass, activeUrl = "", ...restProps }: BottomNavProps = $props();
1010
11-
$effect(() => {
12-
warnThemeDeprecation("BottomNav", { innerClass, outerClass }, { innerClass: "inner", outerClass: "class" });
13-
});
11+
// svelte-ignore state_referenced_locally
12+
warnThemeDeprecation("BottomNav", { innerClass, outerClass }, { innerClass: "inner", outerClass: "class" });
13+
1414
const styling = $derived(classes ?? { inner: innerClass });
1515
1616
// Theme context
@@ -19,7 +19,7 @@
1919
const activeCls = $derived(cn("text-primary-700 dark:text-primary-700 hover:text-primary-900 dark:hover:text-primary-900", activeClass));
2020
2121
// Create reactive context using getters
22-
const reactivecCtx: BottomNavContextType = {
22+
const reactiveCtx: BottomNavContextType = {
2323
get activeClass() {
2424
return activeCls;
2525
},
@@ -31,7 +31,7 @@
3131
}
3232
};
3333
34-
setBottomNavContext(reactivecCtx);
34+
setBottomNavContext(reactiveCtx);
3535
3636
const { base, inner } = $derived(bottomNav({ position, navType }));
3737
</script>

src/lib/bottom-navigation/BottomNavHeader.svelte

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
77
let { children, class: className, classes, outerClass, innerClass, ...restProps }: BottomNavHeaderProps = $props();
88
9-
$effect(() => {
10-
warnThemeDeprecation("BottomNavHeader", { innerClass, outerClass }, { innerClass: "inner", outerClass: "class" });
11-
});
9+
// svelte-ignore state_referenced_locally
10+
warnThemeDeprecation("BottomNavHeader", { innerClass, outerClass }, { innerClass: "inner", outerClass: "class" });
1211
1312
const styling = $derived(classes ?? { innerDiv: innerClass });
1413

src/lib/bottom-navigation/BottomNavItem.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
99
let { children, btnName, appBtnPosition = "middle", activeClass, class: className, classes, btnClass, spanClass, active: manualActive, ...restProps }: BottomNavItemProps = $props();
1010
11-
$effect(() => {
12-
warnThemeDeprecation("BottomNavItem", { spanClass, btnClass }, { spanClass: "span", btnClass: "class" });
13-
});
11+
// svelte-ignore state_referenced_locally
12+
warnThemeDeprecation("BottomNavItem", { spanClass, btnClass }, { spanClass: "span", btnClass: "class" });
13+
1414
const styling = $derived(classes ?? { span: spanClass });
1515
1616
// Theme context

src/lib/breadcrumb/Breadcrumb.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
77
let { children, solid = false, class: className, classes, olClass, ariaLabel = "Breadcrumb", ...restProps }: BreadcrumbProps = $props();
88
9-
$effect(() => {
10-
warnThemeDeprecation("Breadcrumb", { olClass }, { olClass: "list" });
11-
});
9+
// svelte-ignore state_referenced_locally
10+
warnThemeDeprecation("Breadcrumb", { olClass }, { olClass: "list" });
11+
1212
const styling = $derived(classes ?? { list: olClass });
1313
1414
const theme = getTheme("breadcrumb");

src/lib/button-group/ButtonGroup.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
1414
// Create a reactive context object
1515
// The object itself stays the same, but its properties are reactive
16-
const reactivecCtx = {
16+
const reactiveCtx = {
1717
get size() {
1818
return size;
1919
},
@@ -22,7 +22,7 @@
2222
}
2323
};
2424
25-
setButtonGroupContext(reactivecCtx);
25+
setButtonGroupContext(reactiveCtx);
2626
</script>
2727

2828
<div {...restProps} class={groupClass} role="group">

src/lib/card/Card.svelte

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
77
let { children, color = "gray", horizontal = false, shadow = "md", reverse = false, img, size = "sm", class: className, classes, imgClass, ...restProps }: CardProps = $props();
88
9-
$effect(() => {
10-
warnThemeDeprecation("Card", { imgClass }, { imgClass: "image" });
11-
});
9+
// svelte-ignore state_referenced_locally
10+
warnThemeDeprecation("Card", { imgClass }, { imgClass: "image" });
1211
1312
const styling = $derived(classes ?? { image: imgClass });
1413

0 commit comments

Comments
 (0)