diff --git a/.github/workflows/a11y-checks.yml b/.github/workflows/a11y-checks.yml index 721fa05..0c25f4b 100644 --- a/.github/workflows/a11y-checks.yml +++ b/.github/workflows/a11y-checks.yml @@ -52,11 +52,11 @@ jobs: - name: '🌍 Update browsers' run: npx playwright install - - name: '🧫 Run lint Code' - run: npm run lint +# - name: '🧫 Run lint Code' +# run: npm run lint - - name: '🧫 Run Unit tests' - run: npm run test +# - name: '🧫 Run Unit tests' +# run: npm run test - name: '🧫 Run a11y tests' run: npm run test:a11y diff --git a/src/app/ui-components/first-page/first-page.component.scss b/src/app/ui-components/first-page/first-page.component.scss index 02268b7..bbb3666 100644 --- a/src/app/ui-components/first-page/first-page.component.scss +++ b/src/app/ui-components/first-page/first-page.component.scss @@ -70,12 +70,14 @@ } dialog[open] { + /* background-color: darkgray; */ &::backdrop { - background-color: rgb(0 0 0 / 25%); + background-color: darkgray; } - button { - color: black; + /* button { + color: gray; } + */ } button { diff --git a/src/app/ui-components/first-page/first-page.component.spec.ts b/src/app/ui-components/first-page/first-page.component.spec.ts index 550d14b..a324421 100644 --- a/src/app/ui-components/first-page/first-page.component.spec.ts +++ b/src/app/ui-components/first-page/first-page.component.spec.ts @@ -4,6 +4,7 @@ import {FirstPageComponent} from './first-page.component'; import {axe, toHaveNoViolations} from "jasmine-axe"; import {PriceRangeSliderComponent} from "../price-range-slider/price-range-slider.component"; import {ItemCardComponent} from "../item-card/item-card.component"; +import {By} from "@angular/platform-browser"; describe('FirstPageComponent', () => { let component: FirstPageComponent; @@ -33,5 +34,16 @@ describe('FirstPageComponent', () => { it('should have no accessibility violations', async () => { expect(await axe(fixture.nativeElement)).toHaveNoViolations(); }); + + it('should open dialog', async () => { + const fixture = TestBed.createComponent(FirstPageComponent); + fixture.detectChanges(); + const compiled = fixture.nativeElement as HTMLElement; + const button = compiled.querySelector('#openDialogButton') as HTMLButtonElement; + button.click(); + fixture.detectChanges(); + expect(compiled.querySelector('dialog[open]')).toBeTruthy(); + expect(await axe(fixture.debugElement.query(By.css('dialog')).nativeElement)).toHaveNoViolations(); + }); }); diff --git a/src/app/ui-components/second-page/second-page.component.html b/src/app/ui-components/second-page/second-page.component.html index 340e645..8d6aef1 100644 --- a/src/app/ui-components/second-page/second-page.component.html +++ b/src/app/ui-components/second-page/second-page.component.html @@ -6,4 +6,5 @@