Commit ff88a5f
committed
docs(cli): correct the issue citation and reconcile the flake counts
Review findings on #327, both about the comment rather than the test.
The comment said this race was asserted "until #262 work
looked at it", which cites the wrong issue for the work this PR is doing.
#262 reports two subprocess-spawning tests in error-envelope.test.ts and
verify-test-commands.test.ts, a different failure mode, and never names
this one — the PR body says as much, so the comment contradicted it. A
future reader would have opened #262 and found nothing connecting it to
this fixture. The citation is kept rather than dropped, because the causal
chain is real: #262 is where the search started, not what it found.
The comment also said the sibling failed "twice across 13 full-suite runs"
while the sibling's own comment, unchanged, says "once across four
concurrent full-suite runs". Both are true and neither was wrong: they are
two measurement passes, the first while #323 was open and the second
counting captured logs recovered later. Nothing said so, which left two
comments appearing to disagree about the same event.1 parent d9db60a commit ff88a5f
1 file changed
Lines changed: 21 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
268 | 274 | | |
269 | 275 | | |
270 | | - | |
271 | | - | |
272 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
273 | 285 | | |
274 | 286 | | |
275 | 287 | | |
| |||
0 commit comments