Repository navigation
Commit 3845768
committed
docs(cli): explain why rule delete --json stays silent on success
A coordinator review flagged the delete branch's silence under --json
as the same silent-success shape as #280's guard bug, and asked me to
add a success envelope. Before landing that, I found
test/error-envelope.test.ts already asserts the opposite as correct
("is silent on stdout when a real rule is deleted in --json mode"),
introduced deliberately in 07c0d3c. The cli-check and cli-auth
OpenSpec specs both say the standardized envelope applies "when ...
exits with an error" — it is an error-only envelope. create/improve/
meta print on success because they have a payload to return; delete
(like auth logout) does not, so silence is correct, not a bug.
No behavior change. Adds a comment at the call site recording why,
so the next reader (or reviewer) doesn't have to re-derive it.1 parent 3cfbe5b commit 3845768
1 file changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
749 | 749 | | |
750 | 750 | | |
751 | 751 | | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
752 | 762 | | |
753 | 763 | | |
754 | 764 | | |
| |||
0 commit comments