From a2fff47202046cbdfef249811e3ea00c88808ad2 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 5 Mar 2025 08:57:15 -0500 Subject: [PATCH 1/4] Add github action to codespell master on push and PRs --- .github/workflows/codespell.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/workflows/codespell.yml diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml new file mode 100644 index 000000000..b026c855d --- /dev/null +++ b/.github/workflows/codespell.yml @@ -0,0 +1,25 @@ +# Codespell configuration is within .codespellrc +--- +name: Codespell + +on: + push: + branches: [master] + pull_request: + branches: [master] + +permissions: + contents: read + +jobs: + codespell: + name: Check for spelling errors + runs-on: ubuntu-latest + + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: Annotate locations with typos + uses: codespell-project/codespell-problem-matcher@v1 + - name: Codespell + uses: codespell-project/actions-codespell@v2 From c1f25a63ba37d12d3dc04a407b33be1eeaae8d3d Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 5 Mar 2025 08:57:15 -0500 Subject: [PATCH 2/4] Add rudimentary codespell config --- .codespellrc | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .codespellrc diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 000000000..f88da465b --- /dev/null +++ b/.codespellrc @@ -0,0 +1,6 @@ +[codespell] +# Ref: https://github.com/codespell-project/codespell#using-a-config-file +skip = .git*,package-lock.json,*.css,*.min.*,.codespellrc,*.map,dist +check-hidden = true +ignore-regex = this\.browserMobile =.* +ignore-words-list = incase From 73c0933ce855603f7af1905a45f25cb10df18f5a Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 5 Mar 2025 09:00:14 -0500 Subject: [PATCH 3/4] [DATALAD RUNCMD] Do interactive fixing of some ambigous typos === Do not change lines below === { "chain": [], "cmd": "codespell -w -i 3 -C 2 ./src/js/modules/DataTree/DataTree.js", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ --- src/js/modules/DataTree/DataTree.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/modules/DataTree/DataTree.js b/src/js/modules/DataTree/DataTree.js index ec546dee0..9ade0474b 100644 --- a/src/js/modules/DataTree/DataTree.js +++ b/src/js/modules/DataTree/DataTree.js @@ -26,7 +26,7 @@ export default class DataTree extends Module{ this.registerTableOption("dataTreeElementColumn", false); this.registerTableOption("dataTreeBranchElement", true);//show data tree branch element this.registerTableOption("dataTreeChildIndent", 9); //data tree child indent in px - this.registerTableOption("dataTreeChildField", "_children");//data tre column field to look for child rows + this.registerTableOption("dataTreeChildField", "_children");//data tree column field to look for child rows this.registerTableOption("dataTreeCollapseElement", false);//data tree row collapse element this.registerTableOption("dataTreeExpandElement", false);//data tree row expand element this.registerTableOption("dataTreeStartExpanded", false); From 7630df35a0332cb527e645b0269609158b3eb873 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 5 Mar 2025 09:00:16 -0500 Subject: [PATCH 4/4] [DATALAD RUNCMD] run codespell throughout fixing few left typos automagically === Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ --- src/js/core/column/Column.js | 2 +- src/js/core/defaults/options.js | 2 +- src/js/modules/Edit/defaults/editors/date.js | 2 +- src/js/modules/Edit/defaults/editors/datetime.js | 2 +- src/js/modules/Edit/defaults/editors/time.js | 2 +- src/js/modules/Format/defaults/formatters/datetime.js | 2 +- src/js/modules/Format/defaults/formatters/datetimediff.js | 2 +- src/js/modules/GroupRows/GroupRows.js | 4 ++-- src/js/modules/MoveRows/MoveRows.js | 2 +- src/js/modules/Persistence/defaults/readers.js | 2 +- src/js/modules/Sort/defaults/sorters/datetime.js | 2 +- src/scss/themes/bootstrap/functions5.scss | 2 +- src/scss/themes/bootstrap/variables4.scss | 2 +- src/scss/themes/semanticui/tabulator_semanticui.scss | 2 +- 14 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/js/core/column/Column.js b/src/js/core/column/Column.js index 9d0b3bde3..baa06a12d 100644 --- a/src/js/core/column/Column.js +++ b/src/js/core/column/Column.js @@ -324,7 +324,7 @@ export default class Column extends CoreFeature{ this.element.setAttribute("role", "columngroup"); this.element.setAttribute("aria-title", this.definition.title); - //asign additional css classes to column header + //assign additional css classes to column header if(this.definition.cssClass){ var classNames = this.definition.cssClass.split(" "); classNames.forEach((className) => { diff --git a/src/js/core/defaults/options.js b/src/js/core/defaults/options.js index 2e3214072..b41daaad0 100644 --- a/src/js/core/defaults/options.js +++ b/src/js/core/defaults/options.js @@ -15,7 +15,7 @@ export default { popupContainer:false, - columns:[],//store for colum header info + columns:[],//store for column header info columnDefaults:{}, //store column default props rowHeader:false, diff --git a/src/js/modules/Edit/defaults/editors/date.js b/src/js/modules/Edit/defaults/editors/date.js index c1a358496..2e36f2e93 100644 --- a/src/js/modules/Edit/defaults/editors/date.js +++ b/src/js/modules/Edit/defaults/editors/date.js @@ -52,7 +52,7 @@ export default function(cell, onRendered, success, cancel, editorParams){ if(DT){ cellValue = convertDate(cellValue); }else{ - console.error("Editor Error - 'date' editor 'format' param is dependant on luxon.js"); + console.error("Editor Error - 'date' editor 'format' param is dependent on luxon.js"); } } diff --git a/src/js/modules/Edit/defaults/editors/datetime.js b/src/js/modules/Edit/defaults/editors/datetime.js index 293e19b50..db1945093 100644 --- a/src/js/modules/Edit/defaults/editors/datetime.js +++ b/src/js/modules/Edit/defaults/editors/datetime.js @@ -39,7 +39,7 @@ export default function(cell, onRendered, success, cancel, editorParams){ cellValue = newDatetime.toFormat("yyyy-MM-dd") + "T" + newDatetime.toFormat("HH:mm"); }else{ - console.error("Editor Error - 'date' editor 'format' param is dependant on luxon.js"); + console.error("Editor Error - 'date' editor 'format' param is dependent on luxon.js"); } } diff --git a/src/js/modules/Edit/defaults/editors/time.js b/src/js/modules/Edit/defaults/editors/time.js index 2ef9c2bb0..680ca798b 100644 --- a/src/js/modules/Edit/defaults/editors/time.js +++ b/src/js/modules/Edit/defaults/editors/time.js @@ -40,7 +40,7 @@ export default function(cell, onRendered, success, cancel, editorParams){ cellValue = newDatetime.toFormat("HH:mm"); }else{ - console.error("Editor Error - 'date' editor 'format' param is dependant on luxon.js"); + console.error("Editor Error - 'date' editor 'format' param is dependent on luxon.js"); } } diff --git a/src/js/modules/Format/defaults/formatters/datetime.js b/src/js/modules/Format/defaults/formatters/datetime.js index 22c35dcfb..ee941c636 100644 --- a/src/js/modules/Format/defaults/formatters/datetime.js +++ b/src/js/modules/Format/defaults/formatters/datetime.js @@ -32,6 +32,6 @@ export default function(cell, formatterParams, onRendered){ } } }else{ - console.error("Format Error - 'datetime' formatter is dependant on luxon.js"); + console.error("Format Error - 'datetime' formatter is dependent on luxon.js"); } } \ No newline at end of file diff --git a/src/js/modules/Format/defaults/formatters/datetimediff.js b/src/js/modules/Format/defaults/formatters/datetimediff.js index 33b964382..1caf9188a 100644 --- a/src/js/modules/Format/defaults/formatters/datetimediff.js +++ b/src/js/modules/Format/defaults/formatters/datetimediff.js @@ -36,6 +36,6 @@ export default function (cell, formatterParams, onRendered) { } } }else{ - console.error("Format Error - 'datetimediff' formatter is dependant on luxon.js"); + console.error("Format Error - 'datetimediff' formatter is dependent on luxon.js"); } } \ No newline at end of file diff --git a/src/js/modules/GroupRows/GroupRows.js b/src/js/modules/GroupRows/GroupRows.js index 2b50a5884..efc4a417e 100644 --- a/src/js/modules/GroupRows/GroupRows.js +++ b/src/js/modules/GroupRows/GroupRows.js @@ -276,7 +276,7 @@ export default class GroupRows extends Module{ this.trackChanges(); }else{ - console.warn("Grouping Update - cant refresh view, no groups have been set"); + console.warn("Grouping Update - can't refresh view, no groups have been set"); } } @@ -289,7 +289,7 @@ export default class GroupRows extends Module{ this.trackChanges(); }else{ - console.warn("Grouping Update - cant refresh view, no groups have been set"); + console.warn("Grouping Update - can't refresh view, no groups have been set"); } } diff --git a/src/js/modules/MoveRows/MoveRows.js b/src/js/modules/MoveRows/MoveRows.js index 93e6ed569..cd499c270 100644 --- a/src/js/modules/MoveRows/MoveRows.js +++ b/src/js/modules/MoveRows/MoveRows.js @@ -475,7 +475,7 @@ export default class MoveRows extends Module{ }); } - //accept incomming connection + //accept incoming connection connect(table, row){ if(!this.connectedTable){ this.connectedTable = table; diff --git a/src/js/modules/Persistence/defaults/readers.js b/src/js/modules/Persistence/defaults/readers.js index 0e32df5bb..01c64c964 100644 --- a/src/js/modules/Persistence/defaults/readers.js +++ b/src/js/modules/Persistence/defaults/readers.js @@ -1,4 +1,4 @@ -// read persistance information from storage +// read persistence information from storage export default { local:function(id, type){ var data = localStorage.getItem(id + "-" + type); diff --git a/src/js/modules/Sort/defaults/sorters/datetime.js b/src/js/modules/Sort/defaults/sorters/datetime.js index 6dbcbe55e..f2b7327c6 100644 --- a/src/js/modules/Sort/defaults/sorters/datetime.js +++ b/src/js/modules/Sort/defaults/sorters/datetime.js @@ -39,6 +39,6 @@ export default function(a, b, aRow, bRow, column, dir, params){ return emptyAlign; }else{ - console.error("Sort Error - 'datetime' sorter is dependant on luxon.js"); + console.error("Sort Error - 'datetime' sorter is dependent on luxon.js"); } } \ No newline at end of file diff --git a/src/scss/themes/bootstrap/functions5.scss b/src/scss/themes/bootstrap/functions5.scss index 30539b393..a4aea9ed8 100644 --- a/src/scss/themes/bootstrap/functions5.scss +++ b/src/scss/themes/bootstrap/functions5.scss @@ -65,7 +65,7 @@ } // stylelint-enable scss/dollar-variable-pattern -@function varify($list) { +@function verify($list) { $result: null; @each $entry in $list { $result: append($result, var(--#{$variable-prefix}#{$entry}), space); diff --git a/src/scss/themes/bootstrap/variables4.scss b/src/scss/themes/bootstrap/variables4.scss index e1718b54e..fa56122a7 100644 --- a/src/scss/themes/bootstrap/variables4.scss +++ b/src/scss/themes/bootstrap/variables4.scss @@ -900,7 +900,7 @@ $carousel-control-icon-width: 20px !default; $carousel-control-prev-icon-bg: str-replace(url("data:image/svg+xml;charset=utf8,%3Csvg xmlns='http://www.w3.org/2000/svg' fill='#{$carousel-control-color}' viewBox='0 0 8 8'%3E%3Cpath d='M5.25 0l-4 4 4 4 1.5-1.5-2.5-2.5 2.5-2.5-1.5-1.5z'/%3E%3C/svg%3E"), "#", "%23") !default; $carousel-control-next-icon-bg: str-replace(url("data:image/svg+xml;charset=utf8,%3Csvg xmlns='http://www.w3.org/2000/svg' fill='#{$carousel-control-color}' viewBox='0 0 8 8'%3E%3Cpath d='M2.75 0l-1.5 1.5 2.5 2.5-2.5 2.5 1.5 1.5 4-4-4-4z'/%3E%3C/svg%3E"), "#", "%23") !default; -$carousel-transition: transform .6s ease !default; // Define transform transition first if using multiple transitons (e.g., `transform 2s ease, opacity .5s ease-out`) +$carousel-transition: transform .6s ease !default; // Define transform transition first if using multiple transitions (e.g., `transform 2s ease, opacity .5s ease-out`) // Close diff --git a/src/scss/themes/semanticui/tabulator_semanticui.scss b/src/scss/themes/semanticui/tabulator_semanticui.scss index 14fffd347..c5c683799 100644 --- a/src/scss/themes/semanticui/tabulator_semanticui.scss +++ b/src/scss/themes/semanticui/tabulator_semanticui.scss @@ -287,7 +287,7 @@ $footerActiveColor:#d00 !default; //footer bottom active text color } } - //coloured table varients + //coloured table variants /* Red */ &.red { border-top: $coloredBorderSize solid $red;