Improve SimpleMongoRepository.saveAll to use batch updates - #5221
Open
syjdev wants to merge 6 commits into
Open
Conversation
Signed-off-by: syjdev <syjdev@gmail.com>
Signed-off-by: syjdev <syjdev@gmail.com>
Signed-off-by: syjdev <syjdev@gmail.com>
Signed-off-by: syjdev <syjdev@gmail.com>
…ties. Signed-off-by: syjdev <syjdev@gmail.com>
Member
|
As per #5220 (comment), we should seek a consistent bulk approach for inserts and updates, also considering the reactive implementation. |
Author
|
Thank you for the feedback. I'll revise the implementation based on both your comment on #5220 and the feedback you've provided here. Thanks! |
Move the imperative and reactive saveAll(Iterable) onto bulkWrite(...) so that inserts and replaces run within a single ordered bulk. BulkWriter now propagates identifiers generated during the write back to the entity, which saveAll(...) needs to return saved entities. Versioned entities remain saved one by one. Signed-off-by: syjdev <syjdev@gmail.com>
Author
|
I moved both the imperative and the reactive Also, I changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5220