Skip to content

Commit 5b1fd06

Browse files
authored
Publish spotDL 4.2.11 (#2277)
Fix flac scanning when no album art present #2238 @joeyballentine Fix m3u file creation, with correct metadata generation #2258 @Silverarmor Various documentation changes & updates @Silverarmor Bump yt-dlp to 2025.1.15 to attempt to alleviate 403 Forbidden errors.
2 parents 34f867c + 8273124 commit 5b1fd06

File tree

19 files changed

+804
-788
lines changed

19 files changed

+804
-788
lines changed

.github/workflows/standard-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
2727
- name: Run Pylint check
2828
run: |
29-
poetry run pylint --fail-under 10 --limit-inference-results 0 --disable=R0917,W0511 ./spotdl
29+
poetry run pylint --fail-under 10 --limit-inference-results 0 --disable=R0917 ./spotdl
3030
3131
- name: Run MyPy check
3232
run: |

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,3 @@ temp/
145145
# VS Code
146146
.vscode
147147
*.txt
148-
149-
# Output Folder
150-
output/

README.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ For a list of all **options** use ```spotdl -h```
129129
`spotdl sync {filename}.spotdl`
130130

131131
- `meta`: Updates metadata for the provided song files.
132+
132133
</details>
133134

134135
## Music Sourcing and Audio Quality
@@ -149,19 +150,13 @@ Check the [Audio Formats](docs/usage.md#audio-formats-and-quality) page for more
149150
Interested in contributing? Check out our [CONTRIBUTING.md](docs/CONTRIBUTING.md) to find
150151
resources around contributing along with a guide on how to set up a development environment.
151152

152-
#### Join our amazing community as a code contributor, and help accelerate
153+
### Join our amazing community as a code contributor, and help accelerate
154+
153155
<br><br>
154156
<a href="https://github.com/spotDL/spotify-downloader/graphs/contributors">
155157
<img class="dark-light" src="https://contrib.rocks/image?repo=spotDL/spotify-downloader&anon=0&columns=25&max=100&r=true" />
156158
</a>
157-
## Donate
158-
159-
help support the development and maintenance of the software ❤️
160-
161-
[![paypal](https://img.shields.io/badge/paypal-%2300457C.svg?&style=for-the-badge&logo=paypal&logoColor=white)](https://paypal.me/kko7)
162-
[![kofi](https://img.shields.io/badge/kofi-%23F16061.svg?&style=for-the-badge&logo=ko-fi&logoColor=white)](https://ko-fi.com/xnetcat)
163159

164160
## License
165161

166162
This project is Licensed under the [MIT](/LICENSE) License.
167-

docs/CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ everyone involved. The community looks forward to your contributions. 🎉
2727
- [I Want To Contribute](#i-want-to-contribute)
2828
- [Reporting Bugs](#reporting-bugs)
2929
- [Suggesting Enhancements](#suggesting-enhancements)
30-
- [Linting, Formatting and Type-checking](#Linting,-Formatting-and-Type-checking)
31-
- [Python Documentation](#Python-Documentation)
32-
- [Overview of the Project Structure](#Overview-of-the-Project-Structure)
33-
- [Join The Project Team](#Join-The-Project-Team)
30+
- [Linting, Formatting and Type-checking](#linting-formatting-and-type-checking)
31+
- [Python Documentation](#python-documentation)
32+
- [Overview of the Project Structure](#overview-of-the-project-structure)
33+
- [Join The Project Team](#join-the-project-team)
3434

3535
## I Have a Question
3636

@@ -108,7 +108,7 @@ potential bug as fast as possible.
108108
#### How Do I Submit a Good Bug Report?
109109

110110
> You must never report security related issues, vulnerabilities or bugs to the issue tracker,
111-
> or elsewhere in public. Instead sensitive bugs must be sent by discord to xnetcat#8144.
111+
> or elsewhere in public. Instead sensitive bugs must be sent by Discord to Silverarmor (spotDL Discord Owner).
112112
113113
<!-- You may add a PGP key to allow the messages to be sent encrypted as well. -->
114114

@@ -132,7 +132,7 @@ Once it's filed:
132132
addressed until they are reproduced.
133133
- If the team is able to reproduce the issue, it will be marked `needs-fix`, as well as
134134
possibly other tags (such as `critical`), and the issue will be left to be
135-
[implemented by someone](#your-first-code-contribution).
135+
implemented by someone.
136136

137137
<!-- You might want to create an issue template for bugs and errors that can be used as a guide and that defines the structure of the information to be included. If you do so, reference it here in the description. -->
138138

@@ -216,7 +216,7 @@ All changes will now affect the poetry installation of the spotDL cli.
216216
- We use [`pylint`](https://pypi.org/project/pylint/) for linting and expect a score above `9`
217217

218218
```bash
219-
pylint --limit-inference-results 0 --fail-under 9 ./spotdl
219+
pylint --fail-under 10 --limit-inference-results 0 --disable=R0917 ./spotdl
220220
```
221221

222222
- We use [`black`](https://pypi.org/project/black/) for code formatting

docs/index.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Refer to our [Installation Guide](https://spotdl.rtfd.io/en/latest/installation/
4242
- On Termux
4343
- `curl -L https://raw.githubusercontent.com/spotDL/spotify-downloader/master/scripts/termux.sh | sh`
4444
- Arch
45-
- There is an [Arch User Repository (AUR) package](https://aur.archlinux.org/packages/python-spotdl/) for
45+
- There is an [Arch User Repository (AUR) package](https://aur.archlinux.org/packages/spotdl/) for
4646
spotDL.
4747
- Docker
4848
- Build image:
@@ -139,20 +139,13 @@ spotDL uses YouTube as a source for music downloads. This method is used to avoi
139139
140140
spotDL downloads music from YouTube and is designed to always download the highest possible bitrate; which is 128 kbps for regular users and 256 kbps for YouTube Music premium users.
141141
142-
Check the [Audio Formats](usage#audio-formats-and-quality) page for more info.
142+
Check the [Audio Formats](usage.md#audio-formats-and-quality) page for more info.
143143
144144
## Contributing
145145
146-
Interested in contributing? Check out our [CONTRIBUTING.md](CONTRIBUTING) to find
146+
Interested in contributing? Check out our [CONTRIBUTING.md](CONTRIBUTING.md) to find
147147
resources around contributing along with a guide on how to set up a development environment.
148148
149-
## Donate
150-
151-
help support the development and maintenance of the software ❤️
152-
153-
[![paypal](https://img.shields.io/badge/paypal-%2300457C.svg?&style=for-the-badge&logo=paypal&logoColor=white)](https://paypal.me/kko7)
154-
[![kofi](https://img.shields.io/badge/kofi-%23F16061.svg?&style=for-the-badge&logo=ko-fi&logoColor=white)](https://ko-fi.com/xnetcat)
155-
156149
## License
157150
158151
This project is Licensed under the [MIT](/LICENSE) License.

docs/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ We have a dedicated Termux installation script
123123

124124
### Arch User Repository (AUR) package
125125

126-
[You can find the AUR Package here](https://aur.archlinux.org/packages/python-spotdl)
126+
[You can find the AUR Package here](https://aur.archlinux.org/packages/spotdl)
127127

128128
## Where does spotDL download songs?
129129

docs/usage.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,6 @@ If you don't want config to load automatically change `load_config` option in co
281281
"scan_for_songs": false,
282282
"m3u": null,
283283
"output": "{artists} - {title}.{output-ext}",
284-
"m3u_output": "#EXTINF:{duration}, {artists} - {title}.{output-ext}",
285284
"overwrite": "skip",
286285
"search_query": null,
287286
"ffmpeg": "ffmpeg",

0 commit comments

Comments
 (0)