Remove STORAGE_ORDER shader define (playcanvas#8488)

Author: slimbuck

src/scene/gsplat-unified/gsplat-renderer.js

@@ -161,13 +161,12 @@ class GSplatRenderer {
     }
 
     configureMaterial() {
-        const { device, workBuffer } = this;
+        const { workBuffer } = this;
 
         // Inject format's shader chunks (uses workBuffer.format)
         this._injectFormatChunks();
 
         // Set defines
-        this._material.setDefine('STORAGE_ORDER', device.isWebGPU);
         this._material.setDefine('SH_BANDS', '0');
 
         // Set GSPLAT_COLOR_FLOAT define based on work buffer's color format

src/scene/gsplat/gsplat-instance.js

@@ -146,11 +146,9 @@ class GSplatInstance {
     setMaterialOrderData(material) {
         if (this.orderBuffer) {
             material.setParameter('splatOrder', this.orderBuffer);
-            material.setDefine('STORAGE_ORDER', true);
         } else {
             material.setParameter('splatOrder', this.orderTexture);
             material.setParameter('splatTextureSize', this.orderTexture.width);
-            material.setDefine('STORAGE_ORDER', false);
         }
     }
 

src/scene/shader-lib/wgsl/chunks/gsplat/vert/gsplatSource.js

@@ -11,12 +11,7 @@ attribute vertex_id_attrib: u32;          // render order base
 #else
     uniform numSplats: u32;               // total number of splats
 
-    #ifdef STORAGE_ORDER
-        var<storage, read> splatOrder: array<u32>;
-    #else
-        // texture for non-unified gsplat rendering
-        var splatOrder: texture_2d<u32>;
-    #endif
+    var<storage, read> splatOrder: array<u32>;
 #endif
 
 // initialize the splat source structure
@@ -39,12 +34,7 @@ fn initSource(source: ptr<function, SplatSource>) -> bool {
     #ifdef GSPLAT_INDIRECT_DRAW
         splatId = compactedSplatIds[source.order];
     #else
-        #ifdef STORAGE_ORDER
-            splatId = splatOrder[source.order];
-        #else
-            let uv = vec2u(source.order % uniform.splatTextureSize, source.order / uniform.splatTextureSize);
-            splatId = textureLoad(splatOrder, vec2i(uv), 0).r;
-        #endif
+        splatId = splatOrder[source.order];
     #endif
     setSplat(splatId);