Skip to content

Can not handle request error #12

Description

@otaky

Hi,

When request an invalid address, you may got an error like this:

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: connect ETIMEDOUT
    at errnoException (net.js:901:11)
    at Object.afterConnect [as oncomplete] (net.js:892:19)

And I have no good way to handle it.

Maybe HTTPDigest.prototype.request could return its http.ClientRequest object. Like this:

 HTTPDigest.prototype.request = function (options, callback) {
    var self = this;
    var req = http.request(options, function (res) {
      self._handleResponse(options, res, callback);
    });
    req.end();
    return req;
  };

And to handle error like this:

var req = digest.request({
    ...
}, function (res) {
  ...
  res.on('error', function (err) {
    console.log('oh noes');
  });
});

req.on('error', function (err) {
  console.log('request error!');
});

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions