Remove submit-draft-signup e2e test in favor of onboarding-flow test (#3687)

Author: Nateowami

src/SIL.XForge.Scripture/ClientApp/e2e/test-definitions.ts

@@ -7,7 +7,6 @@ import { generateDraft } from './workflows/generate-draft.ts';
 import { localizedScreenshots } from './workflows/localized-screenshots.ts';
 import { onboardingFlow } from './workflows/onboarding-flow.ts';
 import { runSmokeTests, traverseHomePageAndLoginPage } from './workflows/smoke-tests.mts';
-import { submitDraftSignupForm } from './workflows/submit-draft-signup.ts';
 
 export const tests = {
   home_and_login: async (_engine: BrowserType, page: Page, screenshotContext: ScreenshotContext) => {
@@ -25,9 +24,6 @@ export const tests = {
   generate_draft: async (_engine: BrowserType, page: Page, screenshotContext: ScreenshotContext) => {
     await generateDraft(page, screenshotContext, secrets.users[0]);
   },
-  submit_draft_signup: async (_engine: BrowserType, page: Page, screenshotContext: ScreenshotContext) => {
-    await submitDraftSignupForm(page, screenshotContext, secrets.users[0]);
-  },
   onboarding_flow: async (engine: BrowserType, page: Page, screenshotContext: ScreenshotContext) => {
     await onboardingFlow(engine, page, screenshotContext, secrets.users[0]);
   },

src/SIL.XForge.Scripture/ClientApp/e2e/test_characterization.json

@@ -19,10 +19,6 @@
     "success": 13,
     "failure": 0
   },
-  "submit_draft_signup": {
-    "success": 7,
-    "failure": 0
-  },
   "edit_translation": {
     "success": 33,
     "failure": 3

src/SIL.XForge.Scripture/ClientApp/e2e/workflows/onboarding-flow.ts

@@ -113,7 +113,7 @@ export async function onboardingFlow(
     await user.click(btStage);
     await user.click(page.getByRole('option', { name: 'Yes (Up-to-Date)' }));
 
-    await selectProjectByFieldName(page, user, 'Select your back translation', 'DHH94');
+    await selectProjectByFieldName(page, user, 'Select your back translation', 'SEEC2');
 
     const btLangName = page.getByText('Back translation language name');
     await user.click(btLangName);