SG-36435 - PySide 6.8 #67
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/CD testing infrastructure to align with VFX Reference Platform (CY) standards, upgrading Qt wrapper versions and standardizing job naming conventions.
Key Changes:
- Updated Qt wrapper versions: PySide2 pinned to specific versions (5.15.2.1 for CY2022, 5.15.16 for CY2023), PySide6 upgraded to ~=6.5.8 and ~=6.8
- Standardized job naming to include CY year prefixes (e.g., "CY2022 - Windows")
- Modified parameter structure to make Python version and Qt wrapper mandatory while making image_name optional
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/run-tests.yml | Updated all test job configurations with CY-prefixed names and specific Qt wrapper versions; added experimental PySide6~=6.8 configuration for Linux |
| internal/run-tests-with.yml | Reorganized parameters to mark Python version and Qt wrapper as mandatory, moved image_name to optional section |
| internal/pip-install-packages.yml | Added --upgrade flag to pip install command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # | ||
| # - VFX CY2024 | ||
| # - Qt: PySide6=6.2 | ||
| # Python: 3. |
There was a problem hiding this comment.
Incomplete Python version '3.' in comment example - should be '3.10' or similar complete version number.
Suggested change
| # Python: 3. | |
| # Python: 3.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.