Skip to content

Conversation

@julien-lang
Copy link
Contributor

@julien-lang julien-lang commented Oct 8, 2025

This PR changes the way CI scripts access Git repositories.

First it nows uses HTTPS instead of SSH. For making that happens, we create a Git credential manager for the session. The manager simply reads the GH_ACCESS_TOKEN environment variable.

Then, we use the Github Rest API to generate a App Installation Access Token. This token is only valid for 2 hour.

@julien-lang julien-lang requested a review from Copilot October 8, 2025 23:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates authentication from SSH keys to GitHub App tokens for Git operations in Azure DevOps pipelines. The change introduces a Python script to generate GitHub App access tokens and updates the configuration update process to use HTTPS with token-based authentication instead of SSH.

  • Replaces SSH-based Git authentication with GitHub App token authentication
  • Adds Python script to generate GitHub App installation tokens using JWT
  • Updates Git configuration to use GitHub App credentials instead of hardcoded user details

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
internal/update-configuration.yml Adds GitHub App token generation script and updates Git authentication method
internal/release-to-appstore.yml Adds TODO comment about migrating SSH clone to new authentication method
azure-pipelines.yml Adds GitHub App variable group with concern about manual addition to all repos

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@julien-lang julien-lang force-pushed the ticket/SG-40595-migration-toolkitty-github-app branch from c9e9808 to 0d4ecfb Compare October 21, 2025 16:50
@julien-lang julien-lang changed the base branch from master to ticket/SG-40595-minor-improvements October 21, 2025 16:51
@julien-lang julien-lang force-pushed the ticket/SG-40595-migration-toolkitty-github-app branch from 0d4ecfb to ada06f7 Compare October 21, 2025 16:53
Base automatically changed from ticket/SG-40595-minor-improvements to master October 22, 2025 21:15
@julien-lang julien-lang changed the title SG-40595 Test SG-40595 Change Git access to HTTPS using a Github App Dec 5, 2025
@julien-lang julien-lang marked this pull request as ready for review December 5, 2025 00:29
@julien-lang julien-lang requested a review from a team December 5, 2025 00:29
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants