-
Notifications
You must be signed in to change notification settings - Fork 1
SG-40595 Change Git access to HTTPS using a Github App #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SG-40595 Change Git access to HTTPS using a Github App #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates authentication from SSH keys to GitHub App tokens for Git operations in Azure DevOps pipelines. The change introduces a Python script to generate GitHub App access tokens and updates the configuration update process to use HTTPS with token-based authentication instead of SSH.
- Replaces SSH-based Git authentication with GitHub App token authentication
- Adds Python script to generate GitHub App installation tokens using JWT
- Updates Git configuration to use GitHub App credentials instead of hardcoded user details
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/update-configuration.yml | Adds GitHub App token generation script and updates Git authentication method |
| internal/release-to-appstore.yml | Adds TODO comment about migrating SSH clone to new authentication method |
| azure-pipelines.yml | Adds GitHub App variable group with concern about manual addition to all repos |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Better for performance but also to handle incompatibilities
c9e9808 to
0d4ecfb
Compare
0d4ecfb to
ada06f7
Compare
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
This PR changes the way CI scripts access Git repositories.
First it nows uses HTTPS instead of SSH. For making that happens, we create a Git credential manager for the session. The manager simply reads the
GH_ACCESS_TOKENenvironment variable.Then, we use the Github Rest API to generate a App Installation Access Token. This token is only valid for 2 hour.