Feature/pine script v6 improvements #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'tempfile' module for temporary HTML file create - Add URL construction for absolute paths that start with /
- Remove sys.exit() that stopped entire script on first error - Return None on failure to allow script to continue with remaining chapters
- Track successful and failed downloads separately - Add warning message when skipping failed downloads - Display final download statistics at completion
- Create chapters_v6 directory if it doesn't exist - Prevents FileNotFoundError when saving PDFs - Uses os.makedirs with exist_ok=True for safe directory creation
- Replace simple pdfkit.from_url() with comprehensive HTML processing - Fix relative image URLs to absolute URLs for proper image display - Add CSS background image URL fixing with regex processing - Inject custom CSS to remove sidebars and optimize content width - Use temporary HTML files with A3 page size and optimized margins - Add proper cleanup of temporary files on both success and failure - Significantly improves PDF formatting and image inclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the Pine Script documentation PDF converter with Pine Script v6 compatibility, robust error handling, and a better PDF formatting. The original script had limitations that prevented reliable bulk downloads - it was also limit the pdf with narrow text structure - this improvement addresses these issues while maintaining backward compatibility.
Here is some key changes in detail: