ALS Protobuf Parameter Order

[cdr-chakotay]

Hi there,

I recently looked into your great protobuf implementation of the ALS API.
However I recognized in the back of my head, that GrapheneOS implemented something similar recently for their Network Location feature.

I started comparing with their source-code and I stumpled accross the following diffrence.
In your implementation of the ALS Location, you assume the order of the fields reach and score as following:

BaseTrace/apple-location-services/apple-location-services.proto

Lines 34 to 36 in b7b73b3

	optional uint32 reach = 0xb;
	// Assumption: How often the wifi / cell was seen by Apple devices?
	optional int32 score = 0xc;

GrapheneOS implemented this in reverse order:

https://github.com/GrapheneOS/platform_packages_apps_NetworkLocation/blob/f898b68801e0552ec96be8fcbcccf27d8b5c83dc/proto/apple_wps.proto#L71-L72

I would be happy if we could clarify this together.

[lukbukkit]

Hi, thanks for flagging the issue.

I've taken a quick look into the latest iOS build (26.2) and it seems that GrapheneOS' implementation got it right while I mixed up both fields. I'll push a fix in the coming days. Until then, I'm leaving this issue open.

[cdr-chakotay]

Thank you for the swift response.

Great, thanks for clarifying the situation. Much appreciated!