Appearance fixes by KittyBarnett

[akleshchev]

Description

An 'all in one' contribution by KittyBarnett to fix multiple appearance issues.

Repros:

AttachFromWorld
https://github.com/user-attachments/assets/fc37dd4d-a8da-4608-b808-27d6ff2a390c

1. Rez a prim
2. Open inventory with Current Outfits visible
3. Right-click the prim and Wear/Add
4. Not that there's no COF item being created
5. Wear any clothing layer

Observed: the box detaches
Post fix: the box remains attached

Attach+CofDesync
https://github.com/user-attachments/assets/af1fce43-8c86-49c1-8537-3d6a8636230e

1. Rez a prim and take it into inventory
2. Duplicate it three times + rename so you can keep them apart
3. Quickly double-click each one in succession (this may take 2-3 tries)

Observe that only one cube is attached (they all attach to the same pointo so that's correct)
Observed: incorrect COF (one or more of the objects are linked in COF but aren't worn)

1. Detach the one you are wearing

Observed: the detach happens, but another (unexpected to an end user) attachment pops into existence
Post-fix: COF and appearance are sync'ed (the code in llattachmentmgr largely caused this issue)

DetachAfterWear
https://github.com/user-attachments/assets/08cdaa70-ca1f-4727-a7d0-a36943ddbd17

1. Create some wearables (can be default)
2. Create some attachments
3. Select both wearables and attachments and then pick 'Wear'

Observed: the attachments come on, then the wearables, then the attachments detach
Post-fix: everything is worn as you'd expect

DetachAfterWear-2
https://github.com/user-attachments/assets/43d53a2e-fdb4-41fc-ac46-71715f920509

1. Find a wearable that isn't cached locally (you'll have a bit more time for the third double click if the asset needs to fetch - see video)
2. Create two attachments (not attaching to the same point)
3. Double-click the first attachment
4. Double-click the wearble
5. Double-click the second attachment

Observed: perfect example of why syncing attachment inside of a wearable holding pattern is wrong
Post-fix: everything is correctly worn and attached

DetachOnOutfit
https://github.com/user-attachments/assets/7744bb89-05cc-42dc-897c-8bb3f73f51f5

1. Have a prim with the script in it ready to go (accept the permission prompt)
2. Have an outfit ready to go (that isn't local wearable and simulator attachment asset fetched)
3. Replace wear the outfit
4. Immediately click the prim to attach it

Observed: the prim gets lots in the outfit change
Post-fix: the prim remains attached

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #5489 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @akleshchev (replace 20 with the amount, and @akleshchev with the user to tip).

📖 If you want to learn more, check out our documentation.