Improvement/cldsrv 724 object related functional tests #5987

benzekrimaha · 2025-10-24T15:54:19Z

bert-e · 2025-10-24T15:54:23Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

codecov · 2025-10-24T15:56:29Z

❌ 54 Tests Failed:

Tests completed	Failed	Passed	Skipped
6312	54	6258	0

View the top 3 failed test(s) by shortest run time

"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With default signature when user has credential "after all" hook for "should list buckets"

Stack Traces | 0s run time

s3.deleteBucket is not a function

"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "after all" hook for "should list buckets"

Stack Traces | 0s run time

s3.deleteBucket is not a function

"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "before all" hook for "should list buckets concurrently"

Stack Traces | 0s run time

s3.config.update is not a function

"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With default signature when user has credential "before all" hook for "should list buckets concurrently"

Stack Traces | 0.001s run time

s3.config.update is not a function

should abort a multipart upload::aws-node-sdk test suite as registered user should abort a multipart upload

Stack Traces | 0.001s run time

error aborting multipart upload: MissingRequiredParameter: Missing required key 'UploadId' in params

should fail if version id is invalid::PUT object with x-scal-s3-version-id header With v4 signature error handling validation (without cold storage location) should fail if version id is invalid

Stack Traces | 0.015s run time

Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null

should fail if version id is invalid::PUT object with x-scal-s3-version-id header With default signature error handling validation (without cold storage location) should fail if version id is invalid

Stack Traces | 0.017s run time

Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null

"before each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"::aws-node-sdk test suite as registered user Get range on empty object "before each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"

Stack Traces | 0.335s run time

error creating bucket: UnknownEndpoint: Inaccessible host: `ftest-bucketemptyobj-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"::aws-node-sdk test suite as registered user Get range on empty object "after each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"

Stack Traces | 0.587s run time

error deletting object regularly: UnknownEndpoint: Inaccessible host: `ftest-bucketemptyobj-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

View the full list of 45 ❄️ flaky test(s)

downloaded file should equal file that was put::aws-node-sdk v2auth query tests downloaded file should equal file that was put
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.009s run time
Expected values to be strictly equal:

2 !== 0

downloaded file should equal file that was put::aws-node-sdk v4auth query tests downloaded file should equal file that was put
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.007s run time
Expected values to be strictly equal:

2 !== 0

should complete a multipart upload::aws-node-sdk test suite as registered user should complete a multipart upload
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0s run time
error completing mpu: MissingRequiredParameter: Missing required key 'UploadId' in params

should create a bucket::aws-node-sdk test suite as registered user should create a bucket

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.395s run time

error creating bucket: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should create a bucket::aws-node-sdk v2auth query tests should create a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.05s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should create a bucket::aws-node-sdk v4auth query tests should create a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.061s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should create a multipart upload::aws-node-sdk test suite as registered user should create a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.521s run time

error initiating multipart upload: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should delete a bucket::aws-node-sdk test suite as registered user should delete a bucket

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.442s run time

error deleting bucket: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should delete a bucket::aws-node-sdk v2auth query tests should delete a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.035s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete a bucket::aws-node-sdk v4auth query tests should delete a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.016s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete an object put without MPU::aws-node-sdk test suite as registered user should delete an object put without MPU

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.174s run time

error deleting object: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should delete an object with native characters::aws-node-sdk v4auth query tests should delete an object with native characters

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.017s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete an object::aws-node-sdk v2auth query tests should delete an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.016s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete an object::aws-node-sdk v4auth query tests should delete an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.025s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete object created by multipart upload::aws-node-sdk test suite as registered user should delete object created by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.361s run time

error deleting object: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should do a bucket listing with result::aws-node-sdk v4auth query tests should do a bucket listing with result
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.033s run time
Cannot read properties of undefined (reading 'map')

should get a range for an object put without MPU::aws-node-sdk test suite as registered user should get a range for an object put without MPU

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.142s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range for an object using only a start offset in the request::aws-node-sdk test suite as registered user should get a range for an object using only a start offset in the request

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.393s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range for an object using only an end offset in the request::aws-node-sdk test suite as registered user should get a range for an object using only an end offset in the request

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.273s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range from the first part of an object put by multipart upload::aws-node-sdk test suite as registered user should get a range from the first part of an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.36s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range from the second part of an object put by multipart upload and include the end even if the range requested goes beyond the actual object end::aws-node-sdk test suite as registered user should get a range from the second part of an object put by multipart upload and include the end even if the range requested goes beyond the actual object end

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.348s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range from the second part of an object put by multipart upload::aws-node-sdk test suite as registered user should get a range from the second part of an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.43s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range that spans both parts of an object put by multipart upload::aws-node-sdk test suite as registered user should get a range that spans both parts of an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.308s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get an object put by multipart upload::aws-node-sdk test suite as registered user should get an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.408s run time

error getting object put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get an object::aws-node-sdk v2auth query tests should get an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.019s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should get an object::aws-node-sdk v4auth query tests should get an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.016s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should get entire object if range is invalid::aws-node-sdk test suite as registered user should get entire object if range is invalid

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.184s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get full object if range header is invalid::aws-node-sdk test suite as registered user should get full object if range header is invalid

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.339s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should list objects in bucket::aws-node-sdk v4auth query tests should list objects in bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.035s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should list the parts of a multipart upload::aws-node-sdk test suite as registered user should list the parts of a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.001s run time

error listing parts: MissingRequiredParameter: Missing required key 'UploadId' in params

should put an object regularly (non-MPU)::aws-node-sdk test suite as registered user should put an object regularly (non-MPU)

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.427s run time

error putting object regularly: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should put an object with an acl setting and a storage class setting::aws-node-sdk v2auth query tests should put an object with an acl setting and a storage class setting

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.017s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object with an acl setting and a storage class setting::aws-node-sdk v4auth query tests should put an object with an acl setting and a storage class setting

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.024s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object with native characters::aws-node-sdk v4auth query tests should put an object with native characters
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.017s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object::aws-node-sdk v2auth query tests should put an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.044s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object::aws-node-sdk v4auth query tests should put an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.042s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should return 204 on delete of non-existing object::aws-node-sdk v4auth query tests should return 204 on delete of non-existing object

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.039s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should return InvalidRange if the range of the resource does not cover the byte range::aws-node-sdk test suite as registered user should return InvalidRange if the range of the resource does not cover the byte range

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.241s run time

Expected values to be strictly equal:
+ actual - expected

+ 'UnknownEndpoint'
- 'InvalidRange'

should return a 204 on delete of an already deleted object::aws-node-sdk v4auth query tests should return a 204 on delete of an already deleted object

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.059s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should return an error code if expires header is too far in the future::aws-node-sdk v2auth query tests should return an error code if expires header is too far in the future

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.107s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '403 FORBIDDEN'

should return an error code if request occurs after expiry::aws-node-sdk v2auth query tests should return an error code if request occurs after expiry

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 1.55s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '403 FORBIDDEN'

should return an error if do not provide correct xml when completing a multipart upload::aws-node-sdk test suite as registered user should return an error if do not provide correct xml when completing a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.001s run time

Expected values to be strictly equal:
+ actual - expected

+ 'MissingRequiredParameter'
- 'MalformedXML'

should upload a part of a multipart upload to be aborted::aws-node-sdk test suite as registered user should upload a part of a multipart upload to be aborted

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.001s run time

error uploading a part: MissingRequiredParameter: Missing required key 'UploadId' in params

should upload a part of a multipart upload::aws-node-sdk test suite as registered user should upload a part of a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.284s run time

error initiating multipart upload: UnknownEndpoint: Inaccessible host: `ftest-mybucket-3.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should upload a second part of a multipart upload::aws-node-sdk test suite as registered user should upload a second part of a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0s run time

error uploading a part: MissingRequiredParameter: Missing required key 'UploadId' in params

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

ghost · 2025-10-28T08:09:02Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

        `with ${partCount} parts`, done => {
        process.stdout.write('***Running large MPU test***\n');
-        let uploadId;
+        let uploadId;     


Suggested change

let uploadId;

let uploadId;

ghost · 2025-10-28T08:09:11Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

+                    .catch(err => next(err));
+            },
+            next => {
+                process.stdout.write('putting parts\n');


Suggested change

process.stdout.write('putting parts\n');

ghost · 2025-10-28T08:09:24Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

+                        if (err) {
+                            process.stdout.write(`Error in timesLimit: ${err}\n`);
+                        }


Suggested change

if (err) {

process.stdout.write(`Error in timesLimit: ${err}\n`);

}

ghost · 2025-10-28T08:09:45Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

+                    .then(data => {
                        assert.strictEqual(data.ETag,
                                `"${finalETag}-${partCount}"`);
+                        process.stdout.write('get object successful\n');


Suggested change

process.stdout.write('get object successful\n');

ghost · 2025-10-28T08:10:40Z

tests/functional/aws-node-sdk/test/object/copyPart.js

+                        // with number of parts at the end)
                        assert.strictEqual(res.ETag,
                        '"5bba96810ff449d94aa8f5c5a859b0cb-2"');


The indent looks wrong in github diff view

ghost · 2025-10-28T08:13:03Z

tests/functional/aws-node-sdk/test/object/getPartSize.js

+
+            ETags = await Promise.all(uploadPromises);
+
+            // Put empty object


Suggested change

// Put empty object

ghost · 2025-10-28T08:13:07Z

tests/functional/aws-node-sdk/test/object/getPartSize.js

+                Body: '',
+            }));
+
+            // Put non-MPU object


Suggested change

// Put non-MPU object

ghost · 2025-10-28T08:13:11Z

tests/functional/aws-node-sdk/test/object/getPartSize.js

+                Body: generateContent(0),
+            }));
+
+            // Complete multipart upload


Suggested change

// Complete multipart upload

All up 🙏

ghost · 2025-10-28T08:14:23Z

tests/functional/aws-node-sdk/test/object/mpu.js

+            // eslint-disable-next-line no-unused-vars
+            const { $metadata, ...res } = await s3.send(new ListMultipartUploadsCommand({ Bucket: bucket }));


you can as well just save the full object and use .$metadata in the callback? same below in this file

ghost · 2025-10-28T08:15:47Z

tests/functional/aws-node-sdk/test/object/put.js

        it('should put an object and set the acl via query param',
-            done => {
+            async () => {
+                // Create a temporary file for upload


Suggested change

// Create a temporary file for upload

Issue: CLDSRV-724

SylvainSenechal · 2025-12-05T13:14:25Z

tests/functional/aws-node-sdk/test/object/100-continue.js

            const params = {
                Bucket: bucket,
                Key: key,
+                'Content-Length': 0,


never seen this before, do you remember why is it needed suddenly ?

ah i guess sdk v3 more strict

SylvainSenechal

Crazy pr 😅

DarkIsDude

Congrats again. Minor changes but we are good 👏

DarkIsDude · 2025-12-05T16:41:39Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

-        s3.config.update({ maxRetries: 0 });
-        s3.config.update({ httpOptions: { timeout: 0 } });
-        s3.createBucket({ Bucket: bucket }, done);
+        // Custom request handler with no timeouts


Suggested change

// Custom request handler with no timeouts

DarkIsDude · 2025-12-05T16:41:50Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

        `with ${partCount} parts`, done => {
        process.stdout.write('***Running large MPU test***\n');
-        let uploadId;
+        let uploadId;     


DarkIsDude · 2025-12-05T16:42:07Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

+                    .catch(err => next(err));
+            },
+            next => {
+                process.stdout.write('putting parts\n');


DarkIsDude · 2025-12-05T16:42:10Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

+                        if (err) {
+                            process.stdout.write(`Error in timesLimit: ${err}\n`);
+                        }


DarkIsDude · 2025-12-05T16:42:31Z

tests/functional/aws-node-sdk/test/object/bigMpu.js

-                });
+                return s3.send(new CompleteMultipartUploadCommand(params))
+                    .then(() => {
+                        process.stdout.write('mpu completed successfully\n');


DarkIsDude · 2025-12-05T16:55:10Z

tests/functional/aws-node-sdk/test/object/corsHeaders.js

+    const testS3 = new S3Client(config);
+    let capturedHeaders = {};
+
+    // Add middleware to capture response headers (similar to AWS SDK v2's event approach)


DarkIsDude · 2025-12-05T16:55:46Z

tests/functional/aws-node-sdk/test/object/corsHeaders.js

+            try {
+                const result = await next(args);
+
+                // Capture response headers (equivalent to request.on('success'))


I'm not sure it's really useful here. You have that in mind cause you did v2 to v3, but someone new will not understand

DarkIsDude · 2025-12-05T16:57:32Z

tests/functional/aws-node-sdk/test/object/deleteObject.js

+                    name: middlewareName,
+                };
+
+                // Add middleware


Suggested change

// Add middleware

DarkIsDude · 2025-12-05T19:51:29Z

tests/functional/aws-node-sdk/test/object/getPartSize.js

+                Body: generateContent(0),
+            }));
+
+            // Complete multipart upload


All up 🙏

DarkIsDude · 2025-12-05T19:53:31Z

tests/functional/aws-node-sdk/test/object/mpu.js

@@ -1,4 +1,11 @@
+


Remove this line

benzekrimaha changed the base branch from development/9.1 to improvement/CLDSRV-724-multiple-backend-tests October 24, 2025 15:54

scality deleted a comment from bert-e Oct 24, 2025

benzekrimaha force-pushed the improvement/CLDSRV-724-multiple-backend-tests branch 3 times, most recently from 327e859 to 58f8c81 Compare October 27, 2025 14:31

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch 3 times, most recently from 69b2a4a to c56ac68 Compare October 27, 2025 16:32

benzekrimaha marked this pull request as ready for review October 27, 2025 16:33

benzekrimaha force-pushed the improvement/CLDSRV-724-multiple-backend-tests branch from 6d97621 to d8c1d88 Compare October 27, 2025 18:28

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from c56ac68 to 06547e0 Compare October 28, 2025 06:56

ghost approved these changes Oct 28, 2025

View reviewed changes

benzekrimaha force-pushed the improvement/CLDSRV-724-multiple-backend-tests branch 2 times, most recently from f0a4294 to c244695 Compare December 4, 2025 05:52

benzekrimaha added 11 commits December 4, 2025 07:08

tests utilities migration

954f00f

Issue: CLDSRV-724

mpu related tests migration

e6a0e37

Issue: CLDSRV-724

cors related tests migration

319fafa

Issue: CLDSRV-724

get operation related tests migration

8cae616

Issue: CLDSRV-724

copy operation related tests migration

8dd5a90

Issue: CLDSRV-724

put operation related tests migration

0d5f9f1

Issue: CLDSRV-724

delete operation related tests migration

d737d0e

Issue: CLDSRV-724

website related tests migration

e3b43ef

Issue: CLDSRV-724

config migration

c1396ac

Issue: CLDSRV-724

rest of object related tests migration

6f05235

Issue: CLDSRV-724

additional dependencies install

1166011

Issue: CLDSRV-724

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from 06547e0 to 1166011 Compare December 4, 2025 06:10

benzekrimaha requested review from a team and francoisferrand December 4, 2025 14:40

benzekrimaha requested a review from DarkIsDude December 4, 2025 14:40

SylvainSenechal reviewed Dec 5, 2025

View reviewed changes

SylvainSenechal approved these changes Dec 5, 2025

View reviewed changes

DarkIsDude approved these changes Dec 5, 2025

View reviewed changes

	if (err) {
	process.stdout.write(`Error in timesLimit: ${err}\n`);
	}


		ETags = await Promise.all(uploadPromises);

		// Put empty object

		// eslint-disable-next-line no-unused-vars
		const { $metadata, ...res } = await s3.send(new ListMultipartUploadsCommand({ Bucket: bucket }));

Improvement/cldsrv 724 object related functional tests #5987

Are you sure you want to change the base?

Improvement/cldsrv 724 object related functional tests #5987

Conversation

benzekrimaha commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Oct 24, 2025

Hello benzekrimaha,

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 54 Tests Failed:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal left a comment

Choose a reason for hiding this comment

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

benzekrimaha commented Oct 24, 2025 •

edited

Loading

codecov bot commented Oct 24, 2025 •

edited

Loading