Merge branch 'laminas-compat'

* laminas-compat:
  add void in tearDown
  add void in setup
  phpunit compat
  apply laminas compatible by remove Module::getModuleDependencies()

Author: samsonasik

.travis.yml

@@ -3,10 +3,9 @@ dist: trusty
 language: php
 
 php:
-  - 7.1
   - 7.2
   - 7.3
-  
+
 before_install:
   - mkdir -p build/logs
   - composer self-update

composer.json

@@ -18,7 +18,7 @@
         }
     ],
     "require": {
-        "php": "^7.1",
+        "php": "^7.2",
         "zendframework/zend-json": "^2.5 || ^3.0",
         "zendframework/zend-mvc": "^3.0",
         "zendframework/zend-session": "^2.8.4"

src/Module.php

@@ -23,7 +23,6 @@
 
 use Zend\EventManager\EventInterface;
 use Zend\ModuleManager\Feature\ConfigProviderInterface;
-use Zend\ModuleManager\Feature\DependencyIndicatorInterface;
 use Zend\Mvc\Controller\AbstractActionController;
 use Zend\Mvc\MvcEvent;
 use Zend\Session\Container;
@@ -32,7 +31,7 @@
 /**
  * @author Abdul Malik Ikhsan <[email protected]>
  */
-class Module implements ConfigProviderInterface, DependencyIndicatorInterface
+class Module implements ConfigProviderInterface
 {
     /**
      * Bootstrap Handle FlashMessenger session show.
@@ -95,12 +94,4 @@ public function getConfig() : array
     {
         return include __DIR__.'/../config/module.config.php';
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getModuleDependencies() : array
-    {
-        return ['ZendDeveloperTools'];
-    }
 }

test/Collector/SessionCollectorTest.php

@@ -46,7 +46,7 @@ class SessionCollectorTest extends TestCase
     /**
      * initialize properties.
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->sessionCollector = new SessionCollector(new SessionManager());
         $this->sessionContainer = new Container();
@@ -117,7 +117,7 @@ public function testGetSessionDataForEmpty()
         $this->assertEquals([], $this->sessionCollector->getSessionData());
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->sessionContainer->offsetUnset('word');
         $this->sessionContainer->offsetUnset('a');

test/Controller/SessionToolbarControllerTest.php

@@ -29,7 +29,7 @@
  */
 class SessionToolbarControllerTest extends AbstractHttpControllerTestCase
 {
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->setApplicationConfig([
             'modules' => [

test/Factory/Collector/SessionCollectorFactoryTest.php

@@ -36,7 +36,7 @@ class SessionCollectorFactoryTest extends TestCase
     /** @var ContainerInterface */
     protected $serviceLocator;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         /** @var ContainerInterface $serviceLocator */
         $serviceLocator = $this->prophesize('Psr\Container\ContainerInterface');

test/Factory/Controller/SessionToolbarControllerFactoryTest.php

@@ -36,7 +36,7 @@ class SessionToolbarControllerFactoryTest extends TestCase
     /** @var ContainerInterface */
     protected $serviceLocator;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         /** @var ServiceLocatorInterface $serviceLocator */
         $serviceLocator = $this->prophesize('Psr\Container\ContainerInterface');

test/Manager/SessionMangerTest.php

@@ -38,7 +38,7 @@ class SessionMangerTest extends TestCase
     /**
      * initialize properties.
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->manager = new SessionManager();
     }

test/ModuleTest.php

@@ -34,7 +34,7 @@ class ModuleTest extends TestCase
      */
     protected $module;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->module = new Module();
     }
@@ -174,9 +174,4 @@ public function testGetConfig()
     {
         $this->assertTrue(is_array($this->module->getConfig()));
     }
-
-    public function testGetModuleDependencies()
-    {
-        $this->assertEquals(['ZendDeveloperTools'], $this->module->getModuleDependencies());
-    }
 }