chore: Cleanup and bump patch version to v5.0.1

Author: rwese

.github/workflows/publish.yml

@@ -35,34 +35,3 @@ jobs:
 
       - name: Build
         run: npm run build
-
-  publish:
-    needs: test
-    runs-on: ubuntu-latest
-
-    permissions:
-      contents: read
-      packages: write
-      id-token: write
-
-    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-          registry-url: 'https://registry.npmjs.org'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: Build
-        run: npm run build
-
-      - name: Publish to npm
-        run: |
-          echo "Publishing @frugally3683/agent-loop-plugin@$(node -p "require('./package.json').version")"
-          npm publish --access public
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

.woodpecker.yml

@@ -80,30 +80,3 @@ steps:
       - install
     when:
       - event: [push, pull_request, manual, tag]
-
-  # ===========================================================================
-  # Publish to Codeberg npm Registry (on tag events only)
-  # Codeberg is the source of truth - packages are published here
-  # ===========================================================================
-
-  publish:
-    image: node:22-alpine
-    environment:
-      CODEBERG_TOKEN:
-        from_secret: CODEBERG_TOKEN
-    commands:
-      - apk add --no-cache git
-      - |
-        echo "@nope-at:registry=https://codeberg.org/api/packages/nope-at/npm/" > .npmrc
-        echo "//codeberg.org/api/packages/nope-at/npm/:_authToken=$CODEBERG_TOKEN" >> .npmrc
-        cat .npmrc
-        echo "Publishing to Codeberg npm registry..."
-        npm publish --scope=@nope-at --access public
-    depends_on:
-      - typecheck
-      - build
-      - test
-      - lint
-      - format
-    when:
-      - event: tag

__tests__/goal-completion.test.ts

@@ -0,0 +1,100 @@
+/**
+ * Tests for goal completion functionality (completeGoal/goal_done)
+ */
+
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"
+import {
+  createMockPluginContext,
+  createMockFileSystem,
+  setupMockFileSystem,
+} from "./goal-test-setup.js"
+import { createGoalManagement } from "../index.js"
+
+describe("GoalManagement - Goal Completion", () => {
+  let mockFsContext: ReturnType<typeof createMockFileSystem>
+  let mockContext: ReturnType<typeof createMockPluginContext>
+
+  beforeEach(() => {
+    vi.useFakeTimers()
+    mockFsContext = createMockFileSystem()
+    setupMockFileSystem(mockFsContext)
+    mockContext = createMockPluginContext()
+    vi.restoreAllMocks()
+  })
+
+  afterEach(() => {
+    vi.useRealTimers()
+    vi.restoreAllMocks()
+  })
+
+  it("should mark a goal as completed", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    // First create a goal
+    await goalManagement.createGoal(
+      "session-123",
+      "Complete this goal",
+      "Goal is done"
+    )
+
+    // Then complete it
+    const completedGoal = await goalManagement.completeGoal("session-123")
+
+    expect(completedGoal).toBeDefined()
+    expect(completedGoal?.status).toBe("completed")
+    expect(completedGoal?.completed_at).toBeDefined()
+  })
+
+  it("should update goal storage when completing", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    // Reset write call counter for this specific test
+    mockFsContext.writeCalls = []
+
+    // Create and complete goal
+    await goalManagement.createGoal("session-123", "Storage test", "Done")
+    await goalManagement.completeGoal("session-123")
+
+    // Verify writeFile was called for both operations
+    const writeCallsForSession = mockFsContext.writeCalls.filter(
+      call => call[0].includes("session-123")
+    )
+    expect(writeCallsForSession.length).toBeGreaterThanOrEqual(2)
+  })
+
+  it("should return null when completing non-existent goal", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const result = await goalManagement.completeGoal("non-existent-session")
+
+    expect(result).toBeNull()
+  })
+
+  it("should set completed_at timestamp", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    // Create a goal
+    await goalManagement.createGoal("session-123", "Timestamp test", "Done")
+
+    // Get the goal before completion
+    const beforeComplete = await goalManagement.readGoal("session-123")
+
+    // Complete the goal
+    await goalManagement.completeGoal("session-123")
+
+    // Get the goal after completion
+    const afterComplete = await goalManagement.readGoal("session-123")
+
+    expect(beforeComplete?.completed_at).toBeNull()
+    expect(afterComplete?.completed_at).toBeDefined()
+    expect(afterComplete?.completed_at).not.toBeNull()
+  })
+})

__tests__/goal-creation.test.ts

@@ -0,0 +1,116 @@
+/**
+ * Tests for goal creation functionality (createGoal/goal_set)
+ */
+
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"
+import {
+  createMockPluginContext,
+  createMockFileSystem,
+  setupMockFileSystem,
+} from "./goal-test-setup.js"
+import { createGoalManagement } from "../index.js"
+
+describe("GoalManagement - Goal Creation", () => {
+  let mockFsContext: ReturnType<typeof createMockFileSystem>
+  let mockContext: ReturnType<typeof createMockPluginContext>
+
+  beforeEach(() => {
+    vi.useFakeTimers()
+    mockFsContext = createMockFileSystem()
+    setupMockFileSystem(mockFsContext)
+    mockContext = createMockPluginContext()
+    vi.restoreAllMocks()
+  })
+
+  afterEach(() => {
+    vi.useRealTimers()
+    vi.restoreAllMocks()
+  })
+
+  it("should create a new goal with active status", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const goal = await goalManagement.createGoal(
+      "session-123",
+      "Complete the project setup",
+      "All setup tasks are done"
+    )
+
+    expect(goal).toBeDefined()
+    expect(goal.title).toBe("Complete the project setup")
+    expect(goal.done_condition).toBe("All setup tasks are done")
+    expect(goal.status).toBe("active")
+    expect(goal.created_at).toBeDefined()
+    expect(goal.completed_at).toBeNull()
+  })
+
+  it("should create a goal with optional description", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const goal = await goalManagement.createGoal(
+      "session-123",
+      "Build the feature",
+      "Feature is deployed to production",
+      "This is a detailed description of the goal"
+    )
+
+    expect(goal.description).toBe("This is a detailed description of the goal")
+    expect(goal.title).toBe("Build the feature")
+  })
+
+  it("should generate goal with ISO timestamp", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const goal = await goalManagement.createGoal(
+      "session-123",
+      "Test goal",
+      "Test is passing"
+    )
+
+    // Verify timestamp is valid ISO format
+    const timestamp = new Date(goal.created_at)
+    expect(timestamp.toISOString()).toBe(goal.created_at)
+    expect(timestamp.getTime()).toBeGreaterThan(0)
+  })
+
+  it("should store goal in file system", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    await goalManagement.createGoal(
+      "session-123",
+      "Store this goal",
+      "Goal is stored"
+    )
+
+    // Verify writeFile was called
+    const fs = await import("node:fs/promises")
+    expect(fs.writeFile).toHaveBeenCalled()
+    expect(fs.mkdir).toHaveBeenCalled()
+  })
+
+  it("should return the created goal", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const goal = await goalManagement.createGoal(
+      "session-123",
+      "Returnable goal",
+      "Goal can be returned"
+    )
+
+    expect(goal).toHaveProperty("title")
+    expect(goal).toHaveProperty("done_condition")
+    expect(goal).toHaveProperty("status")
+    expect(goal).toHaveProperty("created_at")
+    expect(goal).toHaveProperty("completed_at")
+  })
+})

__tests__/goal-edge-cases.test.ts

@@ -0,0 +1,73 @@
+/**
+ * Tests for edge cases in goal management
+ */
+
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"
+import {
+  createMockPluginContext,
+  createMockFileSystem,
+  setupMockFileSystem,
+} from "./goal-test-setup.js"
+import { createGoalManagement } from "../index.js"
+
+describe("GoalManagement - Edge Cases", () => {
+  let mockFsContext: ReturnType<typeof createMockFileSystem>
+  let mockContext: ReturnType<typeof createMockPluginContext>
+
+  beforeEach(() => {
+    vi.useFakeTimers()
+    mockFsContext = createMockFileSystem()
+    setupMockFileSystem(mockFsContext)
+    mockContext = createMockPluginContext()
+    vi.restoreAllMocks()
+  })
+
+  afterEach(() => {
+    vi.useRealTimers()
+    vi.restoreAllMocks()
+  })
+
+  it("should handle goal with special characters in title", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const goal = await goalManagement.createGoal(
+      "session-123",
+      "Goal with \"quotes\" and 'apostrophes'",
+      "Done"
+    )
+
+    expect(goal.title).toContain("quotes")
+    expect(goal.title).toContain("apostrophes")
+  })
+
+  it("should handle goal with empty description", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const goal = await goalManagement.createGoal(
+      "session-123",
+      "No description",
+      "Done"
+    )
+
+    expect(goal.description).toBeUndefined()
+  })
+
+  it("should handle very long goal title", async () => {
+    const goalManagement = createGoalManagement(mockContext, {
+      goalsBasePath: mockFsContext.basePath,
+    })
+
+    const longTitle = "A".repeat(1000)
+    const goal = await goalManagement.createGoal(
+      "session-123",
+      longTitle,
+      "Done"
+    )
+
+    expect(goal.title.length).toBe(1000)
+  })
+})