Skip to content

Batch load trusted publishing configs and remove unused ones #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kobzol wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Batch load trusted publishing configs and remove unused ones #2160

Kobzol wants to merge 4 commits into from
+171 −37

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 5, 2025

It would be nice to do a dry-run of this, to ensure that we won't be deleting TP configs unexpectedly.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025 •
edited
Loading

Dry-run check results 

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing crates-io
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/flate2-rs':
      Environments:
        ❌ Delete: copilot

@Kobzol Kobzol marked this pull request as draft December 6, 2025 17:43
@Kobzol
Copy link
Member Author

Kobzol commented Dec 6, 2025

Marking as draft, I should implement support for paging first.

@Kobzol Kobzol marked this pull request as ready for review December 6, 2025 18:22
@Kobzol
Copy link
Member Author

Kobzol commented Dec 6, 2025

Ok, implemented now.

@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Dec 7, 2025
@Kobzol
Batch load crates owned by the crates.io user
fccd667 
To avoid N+1 queries to fetch crate information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum Mark-Simulacrum is a code owner

@pietroalbini pietroalbini Awaiting requested review from pietroalbini pietroalbini is a code owner

@jdno jdno Awaiting requested review from jdno jdno is a code owner

@marcoieni marcoieni Awaiting requested review from marcoieni marcoieni is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kobzol @jieyouxu