Adding tests for notification-request (#7)

Author: andrewshell

rsscloud/rsscloud.php

@@ -59,14 +59,16 @@ function rsscloud_parse_request( $wp ) {
 	}
 }
 
-function rsscloud_notify_result( $success, $msg ) {
-	$success = esc_attr( ent2ncr( wp_strip_all_tags( $success ) ) );
-	$msg     = esc_attr( ent2ncr( wp_strip_all_tags( $msg ) ) );
-
-	header( 'Content-Type: text/xml' );
-	echo "<?xml version='1.0'?>\n";
-	echo "<notifyResult success='" . esc_attr( $success ) . "' msg='" . esc_attr( $msg ) . "' />\n";
-	exit;
+if ( ! function_exists( 'rsscloud_notify_result' ) ) {
+	function rsscloud_notify_result( $success, $msg ) {
+		$success = esc_attr( ent2ncr( wp_strip_all_tags( $success ) ) );
+		$msg     = esc_attr( ent2ncr( wp_strip_all_tags( $msg ) ) );
+
+		header( 'Content-Type: text/xml' );
+		echo "<?xml version='1.0'?>\n";
+		echo "<notifyResult success='" . esc_attr( $success ) . "' msg='" . esc_attr( $msg ) . "' />\n";
+		exit;
+	}
 }
 
 add_action( 'rss2_head', 'rsscloud_add_rss_cloud_element' );

tests/bootstrap.php

@@ -25,6 +25,29 @@
 // Give access to tests_add_filter() function.
 require_once "{$_tests_dir}/includes/functions.php";
 
+/**
+ * Exception used to capture rsscloud_notify_result() calls in tests
+ * instead of calling exit().
+ */
+class RsscloudNotifyResultException extends Exception {
+	public $success;
+	public $msg;
+
+	public function __construct( $success, $msg ) {
+		$this->success = $success;
+		$this->msg     = $msg;
+		parent::__construct( "notify_result: success=$success msg=$msg" );
+	}
+}
+
+/**
+ * Test-friendly override of rsscloud_notify_result() that throws
+ * instead of calling exit.
+ */
+function rsscloud_notify_result( $success, $msg ) {
+	throw new RsscloudNotifyResultException( $success, $msg );
+}
+
 /**
  * Manually load the plugin being tested.
  */