-
Notifications
You must be signed in to change notification settings - Fork 5
work on update functions #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,11 @@ | |||
| cli_alert_success <- function(text, .envir = parent.frame()) { | |||
| if (!getOption("babeldown.quiet", FALSE)) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpadge look at me following part of our blog post's advice 😇
| source_lang, | ||
| target_lang, | ||
| formality = c("default", "more", "less", "prefer_more", "prefer_less")) { | ||
| #' Translate Markdown string from clipboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the new stuff in this file!
| #' but containing edits to the source file, like typo fixes, | ||
| #' too much of the target file will be translated automatically again. | ||
| #' | ||
| #' @section Configuration for `deepl_branch_update()`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpadge this explains the configuration
| ) | ||
| } | ||
|
|
||
| deepl_part_translate <- function( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a better name
The plan is for me to use this branch when working on the dev guide release @mpadge.
The big limitation of both update functions is that
New functions
deepl_branch_update()that uses a configuration file and the commits in a branch/PR to update the documents in other languages.deepl_translate_clipboard()that reads from the clipboard and can even guess the source language. Super useful when you know what you need to update/add and where.Improvements that this PR brings to the updating functions