Skip to content

[🧹 CHORE]: Improve Temporal connection error description #2278

@xepozz

Description

@xepozz

No duplicates 🥲.

  • I have searched for a similar issue.

What should be improved or cleaned up?

Running tests in temporal php sdk raises RR fails sometime.
It would be great to see more detailed error, instead of the following:

RR is run with command:

/Users/xepozz/IdeaProjects/temporalio/sdk-php/./rr serve 
-w /Users/xepozz/IdeaProjects/temporalio/sdk-php/tests/Acceptance 
-o temporal.namespace=default 
-o temporal.address=localhost:7233 
-o server.command=/opt/homebrew/Cellar/php@8.3/8.3.23/bin/php,-dxdebug.mode=develop,-dxdebug.start_with_request=default,-dxdebug.start_upon_error=default,/Users/xepozz/IdeaProjects/temporalio/sdk-php/tests/Acceptance/worker.php,namespace=default,address=localhost:7233

Which is run by the temporal php sdk test:

/opt/homebrew/Cellar/php@8.3/8.3.23/bin/php /Users/xepozz/IdeaProjects/temporalio/sdk-php/vendor/phpunit/phpunit/phpunit --configuration /Users/xepozz/IdeaProjects/temporalio/sdk-php/phpunit.xml.dist --filter "/(Temporal\\Tests\\Acceptance\\Extra\\Stability\\ResetWorker\\ResetWorkerTest::resetWithSignal)( .*)?$/" --test-suffix ResetWorkerTest.php /Users/xepozz/IdeaProjects/temporalio/sdk-php/tests/Acceptance/Extra/Stability --teamcity
Testing started at 1:00 PM ...
Starting Temporal test server... done.
Starting RoadRunner... error
Error starting RoadRunner: handle_serve_command: Function call error:
	serve error from the plugin *rrtemporal.Plugin stopping execution, error: temporal_plugin_serve: failed reaching server: context deadline exceeded

Process finished with exit code 1

The errors occurs often if you run tests one by another, manually running the tests from the bottom.
Due to the text of the error error from the plugin *rrtemporal.Plugin seems like it happens because the temporal server isn't ready to accept connections. I'll try to handle such case in temporal php sdk, but the error still needs to be detailed (if any).

Metadata

Metadata

Assignees

Labels

C-enhancementCategory: enhancement. Meaning improvements of current module, transport, etc..

Type

Projects

Status

📋 Backlog

Relationships

None yet

Development

No branches or pull requests

Issue actions