Use top-level Sync instead of plain Fiber for AsyncDataloader

Author: rmosolgo

lib/graphql/analysis/query_complexity.rb

@@ -27,14 +27,14 @@ def result
             future_complexity
           end
         when nil
-          subject.logger.warn <<~GRAPHQL
+          subject.logger.warn <<~MESSAGE
             GraphQL-Ruby's complexity cost system is getting some "breaking fixes" in a future version. See the migration notes at https://graphql-ruby.org/api-doc/#{GraphQL::VERSION}/GraphQL/Schema.html#complexity_cost_calculation_mode_for-class_method
 
             To opt into the future behavior, configure your schema (#{subject.schema.name ? subject.schema.name : subject.schema.ancestors}) with:
 
               complexity_cost_calculation_mode(:future) # or `:legacy`, `:compare`
 
-          GRAPHQL
+          MESSAGE
           max_possible_complexity(mode: :legacy)
         else
           raise ArgumentError, "Expected `:future`, `:legacy`, `:compare`, or `nil` from `#{query.schema}.complexity_cost_calculation_mode_for` but got: #{query.schema.complexity_cost_calculation_mode.inspect}"

lib/graphql/dataloader/async_dataloader.rb

@@ -23,7 +23,9 @@ def run(trace_query_lazy: nil)
         next_source_tasks = []
         first_pass = true
         sources_condition = Async::Condition.new
-        manager = spawn_fiber do
+        fiber_vars = get_fiber_variables
+        Sync do
+          set_fiber_variables(fiber_vars)
           trace&.begin_dataloader(self)
           while first_pass || !job_fibers.empty?
             first_pass = false
@@ -55,12 +57,6 @@ def run(trace_query_lazy: nil)
           end
           trace&.end_dataloader(self)
         end
-
-        manager.resume
-        if manager.alive?
-          raise "Invariant: Manager didn't terminate successfully: #{manager}"
-        end
-
       rescue UncaughtThrowError => e
         throw e.tag, e.value
       end