Fix NPE when navigating away from a screen with RiveUI #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating away from a screen with the RiveUI composable, there's a race condition that can lead to an NPE (stacktrace follows). The issue is that the
RiveSurfaceis nulled out in one callback, while it's asserted to be non-null within a while loop in a coroutine. It is non-deterministic which will be called first, so we have to check whether or notsurfaceis null rather than forcing it to be treated as non-null.