ArrayBuffer support to Java TurboModules - #57062
Closed
paradowstack wants to merge 5 commits into
Closed
paradowstack wants to merge 5 commits into
paradowstack wants to merge 5 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@christophpurrer has imported this pull request. If you are a Meta employee, you can view this in D107411163. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Aug 6, 2026
Summary: Changelog: [ANDROID] [ADDED] - Add ArrayBuffer support to Java TurboModules - Codegen: ArrayBufferTypeAnnotation → ByteBuffer / ArrayBufferKind / Ljava/nio/ByteBuffer; in GenerateModuleJavaSpec and GenerateModuleJniCpp. Guard in Utils.js rejects Promise<ArrayBuffer> on Android at codegen time — drops async return to avoid CxxCallbackImpl.kt / JCallback / PromiseImpl.kt changes. - Runtime: New JByteBufferMutableBuffer.h — jsi::MutableBuffer wrapping global_ref<JByteBuffer> direct ByteBuffer, holds Java object alive for JS ArrayBuffer lifetime; dtor uses ThreadScope to attach JNI thread (Hermes GC finalizes off-thread). Zero-copy native→JS return mirrors iOS NSMutableDataBuffer. Args JS→Java always copied into Java-owned direct ByteBuffer via allocateDirect+memcpy (mirrors iOS NSData copy), no sync/async branching — safe to retain/dispatch past GC. - No changes to CxxCallbackImpl.kt, JCallback, PromiseImpl.kt. Nested ArrayBuffers still via folly::dynamic, deferred like ObjC/C++. - Samples: NativeSampleTurboModule.js spec, SampleTurboModule.kt (getArrayBuffer/ createNativeBuffer/ processAsyncBuffer), RCTSampleTurboModule.mm. (NSData param / NSMutableData return), RNTester UI SampleTurboModuleExample.js. X-link: #57062 Reviewed By: javache Differential Revision: D107411163 Pulled By: christophpurrer fbshipit-source-id: 67cc5da796a87f6918f0382debc5c5594f76661b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ArrayBuffersupport to Java/Kotlin TurboModules, following the C++ ArrayBuffer PR (#56729) and the ObjC ArrayBuffer PR (#56986).ArrayBufferTypeAnnotationin Java module specs (java.nio.ByteBufferparams/returns,ArrayBufferKindin JNI host functions.JMutableDataBuffer—jsi::MutableBufferbacked by a directByteBufferfor zero-copyArrayBufferreturn to JS (withThreadScopein the destructor for Hermes GC finalization)JZeroCopyByteBufferHolder— retains a nativejsi::MutableBufferwhile JNI passes a zero-copyByteBufferview into JavaJavaTurboModule: native-backed zero-copy (holder + view), sync JS-backed borrow (JByteBuffer::wrapBytes), async copy (allocateDirect+memcpy)isSyncwhen return type is not void / Promise (VoidKind/PromiseKindcopy JS-heap inputs; sync methods may borrow for the duration of the call)CxxCallbackImplfast path for a single directByteBufferonPromise.resolve/Callback.invoke(bypassesfolly::dynamic);CxxCallbackRejectImplfor reject-only callbacksThis PR touches some Objective-C++ parts only to get the project building. As soon as Objective-C++ work lands, this PR will be rebased.
Changelog:
[ANDROID] [ADDED] - Add ArrayBuffer support to Java TurboModules
Test plan
array_buffer_native_module(GenerateModuleJavaSpec,GenerateModuleJniCpp,GenerateModuleJniH)getArrayBuffer,createNativeBuffer,processAsyncBuffer,getAsyncBufferonNativeSampleTurboModule(SampleTurboModuleExample.js)BridgingTest.cppArrayBuffer / AsyncArrayBuffer tests from the C++ PR